| Message ID | 20200218133019.22299-4-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [v2,1/4] ARM: dts: rcar-gen2: Add reset control properties for display | expand |
> On February 18, 2020 at 2:30 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > > Add reset control properties to the device nodes for the Display Units > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > only a single reset for each pair of DU channels. > > The display nodes on R-Car V3M and V3H already had "resets" properties, > but lacked the corresponding "reset-names" properties. > > Join the clocks lines while at it, to increase uniformity. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Use "du.0" resp. "du.2" instead of "du.0-1" resp. "du.2-3", > - Drop LVDS reset, as LVDS is now a separate node, > - Add other R-Car Gen3 SoCs. > --- > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 8 ++++---- > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 5 +++-- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 5 +++-- > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 + > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 + > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +-- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 +-- > 7 files changed, 14 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > index 27cbe697490c7c78..52229546454c400a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > @@ -3177,11 +3177,11 @@ > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > - <&cpg CPG_MOD 722>, > - <&cpg CPG_MOD 721>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, > diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi > index ea03b91bdf9d9cbc..31282367d3acd8cf 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi > @@ -2827,10 +2827,11 @@ > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 722>; > clock-names = "du.0", "du.1", "du.2"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index 1a20ebe9ea5be5da..f7468822e81e41d6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -2503,10 +2503,11 @@ > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.3"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.3"; > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm3>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>; > diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > index dbf1c677dbc6e51f..a009c0ebc8b4f8d0 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > @@ -1121,6 +1121,7 @@ > clock-names = "du.0"; > power-domains = <&sysc R8A77970_PD_ALWAYS_ON>; > resets = <&cpg 724>; > + reset-names = "du.0"; > renesas,vsps = <&vspd0 0>; > > status = "disabled"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > index 9444347e61eb881d..e01b0508a18fa91a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -1491,6 +1491,7 @@ > clock-names = "du.0"; > power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > resets = <&cpg 724>; > + reset-names = "du.0"; > renesas,vsps = <&vspd0 0>; > > status = "disabled"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > index c05ee98043b2c7a5..0ad20b78e6eb62fd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -1793,8 +1793,7 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > resets = <&cpg 724>; > reset-names = "du.0"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > index 7d3102dccac96e42..e8d2290fe79d761a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -1026,8 +1026,7 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > resets = <&cpg 724>; > reset-names = "du.0"; > -- > 2.17.1 > Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu> CU Uli
Hi Geert, Thank you for the patch. On Tue, Feb 18, 2020 at 02:30:18PM +0100, Geert Uytterhoeven wrote: > Add reset control properties to the device nodes for the Display Units > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > only a single reset for each pair of DU channels. > > The display nodes on R-Car V3M and V3H already had "resets" properties, > but lacked the corresponding "reset-names" properties. > > Join the clocks lines while at it, to increase uniformity. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Use "du.0" resp. "du.2" instead of "du.0-1" resp. "du.2-3", > - Drop LVDS reset, as LVDS is now a separate node, > - Add other R-Car Gen3 SoCs. > --- > arch/arm64/boot/dts/renesas/r8a77951.dtsi | 8 ++++---- > arch/arm64/boot/dts/renesas/r8a77960.dtsi | 5 +++-- > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 5 +++-- > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 + > arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 + > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +-- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 +-- > 7 files changed, 14 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > index 27cbe697490c7c78..52229546454c400a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi > @@ -3177,11 +3177,11 @@ > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > - <&cpg CPG_MOD 722>, > - <&cpg CPG_MOD 721>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > + <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.2", "du.3"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, > diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi > index ea03b91bdf9d9cbc..31282367d3acd8cf 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi > @@ -2827,10 +2827,11 @@ > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 722>; > clock-names = "du.0", "du.1", "du.2"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.2"; > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; > diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > index 1a20ebe9ea5be5da..f7468822e81e41d6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > @@ -2503,10 +2503,11 @@ > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>, > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 721>; > clock-names = "du.0", "du.1", "du.3"; > + resets = <&cpg 724>, <&cpg 722>; > + reset-names = "du.0", "du.3"; I wonder if this should be du.2, especially given that 722 corresponds to the non-existing DU2 channel. It's a bit of a mess at the hardware level :-S Apart from that the patch looks good to me. > > renesas,cmms = <&cmm0>, <&cmm1>, <&cmm3>; > renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>; > diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > index dbf1c677dbc6e51f..a009c0ebc8b4f8d0 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > @@ -1121,6 +1121,7 @@ > clock-names = "du.0"; > power-domains = <&sysc R8A77970_PD_ALWAYS_ON>; > resets = <&cpg 724>; > + reset-names = "du.0"; > renesas,vsps = <&vspd0 0>; > > status = "disabled"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > index 9444347e61eb881d..e01b0508a18fa91a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi > @@ -1491,6 +1491,7 @@ > clock-names = "du.0"; > power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; > resets = <&cpg 724>; > + reset-names = "du.0"; > renesas,vsps = <&vspd0 0>; > > status = "disabled"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > index c05ee98043b2c7a5..0ad20b78e6eb62fd 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -1793,8 +1793,7 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > resets = <&cpg 724>; > reset-names = "du.0"; > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > index 7d3102dccac96e42..e8d2290fe79d761a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -1026,8 +1026,7 @@ > reg = <0 0xfeb00000 0 0x40000>; > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&cpg CPG_MOD 724>, > - <&cpg CPG_MOD 723>; > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; > clock-names = "du.0", "du.1"; > resets = <&cpg 724>; > reset-names = "du.0";
Hi Laurent, On Wed, Feb 19, 2020 at 4:33 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Tue, Feb 18, 2020 at 02:30:18PM +0100, Geert Uytterhoeven wrote: > > Add reset control properties to the device nodes for the Display Units > > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > > only a single reset for each pair of DU channels. > > > > The display nodes on R-Car V3M and V3H already had "resets" properties, > > but lacked the corresponding "reset-names" properties. > > > > Join the clocks lines while at it, to increase uniformity. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > @@ -2503,10 +2503,11 @@ > > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&cpg CPG_MOD 724>, > > - <&cpg CPG_MOD 723>, > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > <&cpg CPG_MOD 721>; > > clock-names = "du.0", "du.1", "du.3"; > > + resets = <&cpg 724>, <&cpg 722>; > > + reset-names = "du.0", "du.3"; > > I wonder if this should be du.2, especially given that 722 corresponds > to the non-existing DU2 channel. It's a bit of a mess at the hardware Just following the bindings: "du.3" is the lowest channel that is affected by the reset. > level :-S Note that supporting R-Car H3-N will make your^H^H^H^Hthe rcar-du device driver writer's life even more miserable, as suddenly there is no longer a DU2, while the single unified Display Unit node prevents the DTS writer from not setting the DU2's status to "okay" in the board DTS file. But you might look at the ports submode? Gr{oetje,eeting}s, Geert
Hi Geert, On Wed, Feb 19, 2020 at 04:55:52PM +0100, Geert Uytterhoeven wrote: > On Wed, Feb 19, 2020 at 4:33 PM Laurent Pinchart wrote: > > On Tue, Feb 18, 2020 at 02:30:18PM +0100, Geert Uytterhoeven wrote: > > > Add reset control properties to the device nodes for the Display Units > > > on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is > > > only a single reset for each pair of DU channels. > > > > > > The display nodes on R-Car V3M and V3H already had "resets" properties, > > > but lacked the corresponding "reset-names" properties. > > > > > > Join the clocks lines while at it, to increase uniformity. > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi > > > @@ -2503,10 +2503,11 @@ > > > interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; > > > - clocks = <&cpg CPG_MOD 724>, > > > - <&cpg CPG_MOD 723>, > > > + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, > > > <&cpg CPG_MOD 721>; > > > clock-names = "du.0", "du.1", "du.3"; > > > + resets = <&cpg 724>, <&cpg 722>; > > > + reset-names = "du.0", "du.3"; > > > > I wonder if this should be du.2, especially given that 722 corresponds > > to the non-existing DU2 channel. It's a bit of a mess at the hardware > > Just following the bindings: "du.3" is the lowest channel that is affected > by the reset. Yes I was looking at that, and replied to the DT bindings patch. If the outcome of the discussion there is to keep the bindings as-is, you can have my Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> for this whole series. > > level :-S > > Note that supporting R-Car H3-N will make your^H^H^H^Hthe rcar-du device > driver writer's life even more miserable, as suddenly there is no longer > a DU2, while the single unified Display Unit node prevents the DTS > writer from not setting the DU2's status to "okay" in the board DTS > file. But you might look at the ports submode? This will require a separate compatible string I'm afraid.
diff --git a/arch/arm64/boot/dts/renesas/r8a77951.dtsi b/arch/arm64/boot/dts/renesas/r8a77951.dtsi index 27cbe697490c7c78..52229546454c400a 100644 --- a/arch/arm64/boot/dts/renesas/r8a77951.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77951.dtsi @@ -3177,11 +3177,11 @@ <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>, - <&cpg CPG_MOD 722>, - <&cpg CPG_MOD 721>; + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, + <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3"; + resets = <&cpg 724>, <&cpg 722>; + reset-names = "du.0", "du.2"; renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>, <&cmm3>; renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, diff --git a/arch/arm64/boot/dts/renesas/r8a77960.dtsi b/arch/arm64/boot/dts/renesas/r8a77960.dtsi index ea03b91bdf9d9cbc..31282367d3acd8cf 100644 --- a/arch/arm64/boot/dts/renesas/r8a77960.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77960.dtsi @@ -2827,10 +2827,11 @@ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>, + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 722>; clock-names = "du.0", "du.1", "du.2"; + resets = <&cpg 724>, <&cpg 722>; + reset-names = "du.0", "du.2"; renesas,cmms = <&cmm0>, <&cmm1>, <&cmm2>; renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>; diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index 1a20ebe9ea5be5da..f7468822e81e41d6 100644 --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi @@ -2503,10 +2503,11 @@ interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 270 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>, + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>, <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.3"; + resets = <&cpg 724>, <&cpg 722>; + reset-names = "du.0", "du.3"; renesas,cmms = <&cmm0>, <&cmm1>, <&cmm3>; renesas,vsps = <&vspd0 0>, <&vspd1 0>, <&vspd0 1>; diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi b/arch/arm64/boot/dts/renesas/r8a77970.dtsi index dbf1c677dbc6e51f..a009c0ebc8b4f8d0 100644 --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi @@ -1121,6 +1121,7 @@ clock-names = "du.0"; power-domains = <&sysc R8A77970_PD_ALWAYS_ON>; resets = <&cpg 724>; + reset-names = "du.0"; renesas,vsps = <&vspd0 0>; status = "disabled"; diff --git a/arch/arm64/boot/dts/renesas/r8a77980.dtsi b/arch/arm64/boot/dts/renesas/r8a77980.dtsi index 9444347e61eb881d..e01b0508a18fa91a 100644 --- a/arch/arm64/boot/dts/renesas/r8a77980.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77980.dtsi @@ -1491,6 +1491,7 @@ clock-names = "du.0"; power-domains = <&sysc R8A77980_PD_ALWAYS_ON>; resets = <&cpg 724>; + reset-names = "du.0"; renesas,vsps = <&vspd0 0>; status = "disabled"; diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index c05ee98043b2c7a5..0ad20b78e6eb62fd 100644 --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi @@ -1793,8 +1793,7 @@ reg = <0 0xfeb00000 0 0x40000>; interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>; + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; clock-names = "du.0", "du.1"; resets = <&cpg 724>; reset-names = "du.0"; diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index 7d3102dccac96e42..e8d2290fe79d761a 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -1026,8 +1026,7 @@ reg = <0 0xfeb00000 0 0x40000>; interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&cpg CPG_MOD 724>, - <&cpg CPG_MOD 723>; + clocks = <&cpg CPG_MOD 724>, <&cpg CPG_MOD 723>; clock-names = "du.0", "du.1"; resets = <&cpg 724>; reset-names = "du.0";
Add reset control properties to the device nodes for the Display Units on all supported R-Car Gen3 SoCs. Note that on these SoCs, there is only a single reset for each pair of DU channels. The display nodes on R-Car V3M and V3H already had "resets" properties, but lacked the corresponding "reset-names" properties. Join the clocks lines while at it, to increase uniformity. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - Use "du.0" resp. "du.2" instead of "du.0-1" resp. "du.2-3", - Drop LVDS reset, as LVDS is now a separate node, - Add other R-Car Gen3 SoCs. --- arch/arm64/boot/dts/renesas/r8a77951.dtsi | 8 ++++---- arch/arm64/boot/dts/renesas/r8a77960.dtsi | 5 +++-- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 5 +++-- arch/arm64/boot/dts/renesas/r8a77970.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77980.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77990.dtsi | 3 +-- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 3 +-- 7 files changed, 14 insertions(+), 12 deletions(-)