fstests: add perf to the list of test directories
diff mbox series

Message ID 20200218142945.3719579-1-josef@toxicpanda.com
State New
Headers show
Series
  • fstests: add perf to the list of test directories
Related show

Commit Message

Josef Bacik Feb. 18, 2020, 2:29 p.m. UTC
I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
perf/ tests run when I used -g auto.  This is because it's not included
in the list of directories to look at.  Fix this so that perf tests get
run as well.

Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
 check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zorro Lang Feb. 19, 2020, 11:52 a.m. UTC | #1
On Tue, Feb 18, 2020 at 09:29:45AM -0500, Josef Bacik wrote:
> I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
> perf/ tests run when I used -g auto.  This is because it's not included
> in the list of directories to look at.  Fix this so that perf tests get
> run as well.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 89f3358a..9e7b6134 100755
> --- a/check
> +++ b/check
> @@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
>  
>  rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
>  
> -SRC_GROUPS="generic shared"
> +SRC_GROUPS="generic shared perf"

Looks good to me, if the maintainer won't prefer moving perf/001 to generic/ :)

Thanks,
Zorro

>  export SRC_DIR="tests"
>  
>  usage()
> -- 
> 2.24.1
>
Eryu Guan Feb. 23, 2020, 12:56 p.m. UTC | #2
On Tue, Feb 18, 2020 at 09:29:45AM -0500, Josef Bacik wrote:
> I noticed that despite having PERF_CONFIGNAME set I wasn't getting the
> perf/ tests run when I used -g auto.  This is because it's not included
> in the list of directories to look at.  Fix this so that perf tests get
> run as well.
> 
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

I don't think the perf test infra is widely used by developers and
testers yet, so adding perf tests to default 'auto' tests would bring
unexpected failures.

So I think it's better to keep it not run by default for now, and if you
want to run perf tests in your test env, you could do it easily by
adding "-g perf/auto" option to "./check", e.g.

	./check -g auto -g perf/auto

And if there're frequent users of the perf infra, please reply this
thread and let us know, it'd be interesting to know how many users are
there.

Thanks,
Eryu

> ---
>  check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/check b/check
> index 89f3358a..9e7b6134 100755
> --- a/check
> +++ b/check
> @@ -44,7 +44,7 @@ timestamp=${TIMESTAMP:=false}
>  
>  rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
>  
> -SRC_GROUPS="generic shared"
> +SRC_GROUPS="generic shared perf"
>  export SRC_DIR="tests"
>  
>  usage()
> -- 
> 2.24.1
>

Patch
diff mbox series

diff --git a/check b/check
index 89f3358a..9e7b6134 100755
--- a/check
+++ b/check
@@ -44,7 +44,7 @@  timestamp=${TIMESTAMP:=false}
 
 rm -f $tmp.list $tmp.tmp $tmp.grep $here/$iam.out $tmp.xlist $tmp.report.*
 
-SRC_GROUPS="generic shared"
+SRC_GROUPS="generic shared perf"
 export SRC_DIR="tests"
 
 usage()