[4/5] libxl/PCI: pass correct "hotplug" argument to libxl__device_pci_setdefault()
diff mbox series

Message ID c7adfa84-2310-3d1d-a6db-574a10247380@suse.com
State New
Headers show
Series
  • libxl/PCI: reserved device memory adjustments
Related show

Commit Message

Jan Beulich Feb. 18, 2020, 3:47 p.m. UTC
Uniformly passing "false" can't be right, but has been benign because of
the function not using this parameter.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Wei Liu Feb. 20, 2020, 11:41 a.m. UTC | #1
On Tue, Feb 18, 2020 at 04:47:27PM +0100, Jan Beulich wrote:
> Uniformly passing "false" can't be right, but has been benign because of
> the function not using this parameter.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Wei Liu <wl@xen.org>

Patch
diff mbox series

--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1567,7 +1567,7 @@  void libxl__device_pci_add(libxl__egc *e
         }
     }
 
-    rc = libxl__device_pci_setdefault(gc, domid, pcidev, false);
+    rc = libxl__device_pci_setdefault(gc, domid, pcidev, !starting);
     if (rc) goto out;
 
     if (pcidev->seize && !pciback_dev_is_assigned(gc, pcidev)) {