| Message ID | 20200218155534.15504-2-wambui.karugax@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/tilcdc: remove check for return value of debugfs functions. | expand |
On 18/02/2020 17:55, Wambui Karuga wrote: > Remove the check and error handling of the return value of > drm_debugfs_create_files as it is not needed in tilcdc_debugfs_init. > Also remove local variables that are not used after the changes. > > Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> Reviewed-by: Jyri Sarha <jsarha@ti.com> Tested-by: Jyri Sarha <jsarha@ti.com> I'll merge this to drm-misc-next tomorrow. Thank you for the patch, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index 0791a0200cc3..3f7071eb9c78 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -480,24 +480,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = { > > static int tilcdc_debugfs_init(struct drm_minor *minor) > { > - struct drm_device *dev = minor->dev; > struct tilcdc_module *mod; > - int ret; > > - ret = drm_debugfs_create_files(tilcdc_debugfs_list, > - ARRAY_SIZE(tilcdc_debugfs_list), > - minor->debugfs_root, minor); > + drm_debugfs_create_files(tilcdc_debugfs_list, > + ARRAY_SIZE(tilcdc_debugfs_list), > + minor->debugfs_root, minor); > > list_for_each_entry(mod, &module_list, list) > if (mod->funcs->debugfs_init) > mod->funcs->debugfs_init(mod, minor); > > - if (ret) { > - dev_err(dev->dev, "could not install tilcdc_debugfs_list\n"); > - return ret; > - } > - > - return ret; > + return 0; > } > #endif > >
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 0791a0200cc3..3f7071eb9c78 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -480,24 +480,17 @@ static struct drm_info_list tilcdc_debugfs_list[] = { static int tilcdc_debugfs_init(struct drm_minor *minor) { - struct drm_device *dev = minor->dev; struct tilcdc_module *mod; - int ret; - ret = drm_debugfs_create_files(tilcdc_debugfs_list, - ARRAY_SIZE(tilcdc_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(tilcdc_debugfs_list, + ARRAY_SIZE(tilcdc_debugfs_list), + minor->debugfs_root, minor); list_for_each_entry(mod, &module_list, list) if (mod->funcs->debugfs_init) mod->funcs->debugfs_init(mod, minor); - if (ret) { - dev_err(dev->dev, "could not install tilcdc_debugfs_list\n"); - return ret; - } - - return ret; + return 0; } #endif
Remove the check and error handling of the return value of drm_debugfs_create_files as it is not needed in tilcdc_debugfs_init. Also remove local variables that are not used after the changes. Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com> --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-)