From patchwork Wed Feb 19 10:20:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11391037 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A30901580 for ; Wed, 19 Feb 2020 10:22:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 815492464E for ; Wed, 19 Feb 2020 10:22:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iTjPsPk6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 815492464E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D24D76EB54; Wed, 19 Feb 2020 10:22:15 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 396F26EB36 for ; Wed, 19 Feb 2020 10:21:52 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id w15so27527312wru.4 for ; Wed, 19 Feb 2020 02:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Dh+h123bCHKEifl005lcLLj+b1SNMqbXcgH++6BKO1o=; b=iTjPsPk64jJsWTNo2ENnof9YjZO5s2n0SkROUEQHyg9XcovxzPHyLkZGo88QPvTVZq BlGIq9rXTHkbWSKHh3Eu7H33LZKAaiQ3mwjKg9UB/Jx7qQSND9pk5L7RL4qSULMmlL6E VCdJoMRI0Aie6qZUxs2ej0N2ExxIR5WEp8lZE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dh+h123bCHKEifl005lcLLj+b1SNMqbXcgH++6BKO1o=; b=PN9hNS7U4Un2A0dA2ZUv+VzhymrMGz4qrTths9+uGPGhakZrIwtezuMVtjx6wTseFV abvKsrMMPpZJKFUodkO6tHDWxxUu30BMtP89qyXIIAx/ycqn/gtaq1zyNPdeMqde5H/7 vc9npo1Y/BgKPGrdGXWh7ZHRCBT+yH/mrLPKqthAuuB3+timeZxxLgJH3ihD/9lu1Z3g 4CkIXKKCkXkw/gTYn1bAxAApjcr4wqaxssRUyICIej0EP0Wx+YD2NV7XbVn1dIwliDlA pip6qhIQs9YOTjqWOY2f9rS60IELu1pMr7GTFMEzUks9hOHTHzYXhTKbjEzgv/JUyH4M 7ZEA== X-Gm-Message-State: APjAAAUesWBHJbzCibY6XCW6I2vJQ/D8kre9u2ecMBLk8iP91vRd7Vdj WrhuUYydNqJLhbks9UvXvNewO5p/h2o= X-Google-Smtp-Source: APXvYqz1NarCJJY9ejf8GJKo+4Tu5qDpSLiZO3ySfykZSN4LQuAKGymih2Kog1Rx9tSbEZoirMHcow== X-Received: by 2002:adf:c54e:: with SMTP id s14mr33820773wrf.385.1582107710557; Wed, 19 Feb 2020 02:21:50 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id s23sm2370339wra.15.2020.02.19.02.21.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 02:21:50 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 16/52] drm/repaper: Use drmm_add_final_kfree Date: Wed, 19 Feb 2020 11:20:46 +0100 Message-Id: <20200219102122.1607365-17-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200219102122.1607365-1-daniel.vetter@ffwll.ch> References: <20200219102122.1607365-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With this we can drop the final kfree from the release function. Signed-off-by: Daniel Vetter Cc: "Noralf Trønnes" Reviewed-by: Noralf Trønnes --- drivers/gpu/drm/tiny/repaper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tiny/repaper.c b/drivers/gpu/drm/tiny/repaper.c index f5ebcaf7ee3a..df5654ef53ee 100644 --- a/drivers/gpu/drm/tiny/repaper.c +++ b/drivers/gpu/drm/tiny/repaper.c @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include @@ -910,13 +911,10 @@ static const struct drm_mode_config_funcs repaper_mode_config_funcs = { static void repaper_release(struct drm_device *drm) { - struct repaper_epd *epd = drm_to_epd(drm); - DRM_DEBUG_DRIVER("\n"); drm_mode_config_cleanup(drm); drm_dev_fini(drm); - kfree(epd); } static const uint32_t repaper_formats[] = { @@ -1024,6 +1022,7 @@ static int repaper_probe(struct spi_device *spi) kfree(epd); return ret; } + drmm_add_final_kfree(drm, epd); drm_mode_config_init(drm); drm->mode_config.funcs = &repaper_mode_config_funcs;