From patchwork Wed Feb 19 11:19:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 11391259 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B7C614E3 for ; Wed, 19 Feb 2020 11:20:37 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 543F1206E2 for ; Wed, 19 Feb 2020 11:20:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="Mq2pHGYp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 543F1206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4NNn-00019K-2t; Wed, 19 Feb 2020 11:19:11 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j4NNm-00019F-01 for xen-devel@lists.xenproject.org; Wed, 19 Feb 2020 11:19:10 +0000 X-Inumbo-ID: a5881a74-5309-11ea-ade5-bc764e2007e4 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a5881a74-5309-11ea-ade5-bc764e2007e4; Wed, 19 Feb 2020 11:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1582111148; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=zCmKs9h2O/do2KEhX6tjsIUbwjr+ps54yuHOsAQjLME=; b=Mq2pHGYpwXTmvNoBFoR5EuuvV4OCePrckPsbPScOnGbk+O2yFofkhwte +MxE19ybbIt5ZyspbcsKIsv95YJBfc4o9zOw42UqJeTVeYyOWpxcn7waP eGvOTVEvL39mZK1ywwQ1ahmZFSibWVEOeO8eSqobaqezLBjgcW9wwll5V M=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: o+xzUE+b2cn1zOnk0HiVy1FvWH37BAQBzaqStpUw6aGMNbRlaJ0On8dmxatp7wzW4MvwpZwlhJ evJji6bAaSUQafVI/mzLj1QrMiG42DEpcfu53TnTURLreJd3zScXMj2+FK1COjmhUvhPyUYjcU FHsWIIw8a9vgPDLYJlrs+8Kkfsxn9uim2icMxAV3IDsjhwxldIq6c4fQRtQKPp4rv4HPGUj3je RcztMy51pZgLT4o4CJNeXpyTpZP+QQma9Qm2NMtC7z2l6Lif3HHmfokE+DRDitzTSYe+pTxGN3 bf8= X-SBRS: 2.7 X-MesageID: 13113641 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,459,1574139600"; d="scan'208";a="13113641" From: Roger Pau Monne To: Date: Wed, 19 Feb 2020 12:19:04 +0100 Message-ID: <20200219111904.82092-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] amd/iommu: add missing unlock in iommu_read_log X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Andrew Cooper , Jan Beulich , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Reported-by: Coverity CID: 1458632 Fixes: 709d3ddea2d5e ('AMD/IOMMU: Common the #732/#733 errata handling in iommu_read_log()') Signed-off-by: Roger Pau Monné --- xen/drivers/passthrough/amd/iommu_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 4c86848c52..e93a090830 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -338,6 +338,7 @@ static int iommu_read_log(struct amd_iommu *iommu, { AMD_IOMMU_DEBUG("AMD-Vi: No entry written to %s Log\n", log == &iommu->event_log ? "Event" : "PPR"); + spin_unlock(&log->lock); return 0; } udelay(1);