| Message ID | 20200220002047.115000-1-swboyd@chromium.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | watchdog: qcom: Use irq flags from firmware | expand |
On Wed 19 Feb 16:20 PST 2020, Stephen Boyd wrote: > The DT or ACPI tables should tell the driver what the irq flags are. > Given that this driver probes only on DT based platforms and those DT > platforms specify the irq flags we can safely drop the forced irq flag > setting here. > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/watchdog/qcom-wdt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index eb47fe5ed280..c70e89013101 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -248,8 +248,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > /* check if there is pretimeout support */ > irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > - ret = devm_request_irq(dev, irq, qcom_wdt_isr, > - IRQF_TRIGGER_RISING, > + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0, > "wdt_bark", &wdt->wdd); > if (ret) > return ret; > -- > Sent by a computer, using git, on the internet >
On 2/19/20 4:20 PM, Stephen Boyd wrote: > The DT or ACPI tables should tell the driver what the irq flags are. > Given that this driver probes only on DT based platforms and those DT > platforms specify the irq flags we can safely drop the forced irq flag > setting here. > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/watchdog/qcom-wdt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index eb47fe5ed280..c70e89013101 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -248,8 +248,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) > /* check if there is pretimeout support */ > irq = platform_get_irq_optional(pdev, 0); > if (irq > 0) { > - ret = devm_request_irq(dev, irq, qcom_wdt_isr, > - IRQF_TRIGGER_RISING, > + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0, > "wdt_bark", &wdt->wdd); > if (ret) > return ret; >
On 2020-02-20 05:50, Stephen Boyd wrote: > The DT or ACPI tables should tell the driver what the irq flags are. > Given that this driver probes only on DT based platforms and those DT > platforms specify the irq flags we can safely drop the forced irq flag > setting here. > > Cc: Andy Gross <agross@kernel.org> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> Thanks, Reviewed-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c index eb47fe5ed280..c70e89013101 100644 --- a/drivers/watchdog/qcom-wdt.c +++ b/drivers/watchdog/qcom-wdt.c @@ -248,8 +248,7 @@ static int qcom_wdt_probe(struct platform_device *pdev) /* check if there is pretimeout support */ irq = platform_get_irq_optional(pdev, 0); if (irq > 0) { - ret = devm_request_irq(dev, irq, qcom_wdt_isr, - IRQF_TRIGGER_RISING, + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0, "wdt_bark", &wdt->wdd); if (ret) return ret;
The DT or ACPI tables should tell the driver what the irq flags are. Given that this driver probes only on DT based platforms and those DT platforms specify the irq flags we can safely drop the forced irq flag setting here. Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/watchdog/qcom-wdt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)