| Message ID | 20200220145127.21273-3-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [1/3] regulator: max14577: Add proper dt-compatible strings | expand |
On Thu, Feb 20, 2020 at 03:51:27PM +0100, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/power/supply/max14577_charger.c | 9 +++++++++ > 1 file changed, 9 insertions(+) The approach is still being discussed (in patch #1) so this should be applied if patch #1 is also accepted. In such case: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
Hi, On Thu, Feb 20, 2020 at 03:51:27PM +0100, Marek Szyprowski wrote: > Add device tree compatible strings and create proper modalias structures > to let this driver load automatically if compiled as module, because > max14577 MFD driver creates MFD cells with such compatible strings. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/power/supply/max14577_charger.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c > index 8a59feac6468..891ba9f6f295 100644 > --- a/drivers/power/supply/max14577_charger.c > +++ b/drivers/power/supply/max14577_charger.c > @@ -623,6 +623,15 @@ static const struct platform_device_id max14577_charger_id[] = { > }; > MODULE_DEVICE_TABLE(platform, max14577_charger_id); > > +static const struct of_device_id of_max14577_charger_dt_match[] = { > + { .compatible = "maxim,max77836-charger", > + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, > + { .compatible = "maxim,max14577-charger", > + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match); > + > static struct platform_driver max14577_charger_driver = { > .driver = { > .name = "max14577-charger", Independently of the discussion in patch 1 this is missing the link to the of table in platform_driver->driver->of_match_table. -- Sebastian
diff --git a/drivers/power/supply/max14577_charger.c b/drivers/power/supply/max14577_charger.c index 8a59feac6468..891ba9f6f295 100644 --- a/drivers/power/supply/max14577_charger.c +++ b/drivers/power/supply/max14577_charger.c @@ -623,6 +623,15 @@ static const struct platform_device_id max14577_charger_id[] = { }; MODULE_DEVICE_TABLE(platform, max14577_charger_id); +static const struct of_device_id of_max14577_charger_dt_match[] = { + { .compatible = "maxim,max77836-charger", + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, }, + { .compatible = "maxim,max14577-charger", + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, }, + { }, +}; +MODULE_DEVICE_TABLE(of, of_max14577_charger_dt_match); + static struct platform_driver max14577_charger_driver = { .driver = { .name = "max14577-charger",
Add device tree compatible strings and create proper modalias structures to let this driver load automatically if compiled as module, because max14577 MFD driver creates MFD cells with such compatible strings. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/power/supply/max14577_charger.c | 9 +++++++++ 1 file changed, 9 insertions(+)