| Message ID | 20200221033640.55163-3-jaedon.shin@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PCI: brcmstb: Add Broadcom STB support | expand |
On Fri, 21 Feb 2020 12:36:40 +0900, Jaedon Shin wrote: > devm_clk_get* APIs are device managed and get freed automatically when > the device detaches. so there is no reason to explicitly call clk_put() > in probe or remove functions. > > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host > controller driver") > Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com> > Acked-by: Florian Fainelli <f.fainelli@gmail.com> > Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- > drivers/pci/controller/pcie-brcmstb.c | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c index 8968ef7fa55d..cbb587eb8d39 100644 --- a/drivers/pci/controller/pcie-brcmstb.c +++ b/drivers/pci/controller/pcie-brcmstb.c @@ -903,7 +903,6 @@ static void __brcm_pcie_remove(struct brcm_pcie *pcie) brcm_pcie_turn_off(pcie); regulator_bulk_disable(pcie->num_vregs, pcie->vreg_bulk); clk_disable_unprepare(pcie->clk); - clk_put(pcie->clk); } static int brcm_pcie_remove(struct platform_device *pdev)
devm_clk_get* APIs are device managed and get freed automatically when the device detaches. so there is no reason to explicitly call clk_put() in probe or remove functions. Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver") Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> --- drivers/pci/controller/pcie-brcmstb.c | 1 - 1 file changed, 1 deletion(-)