[RESEND2] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal
diff mbox series

Message ID 20200221140455.8713068BFE@verein.lst.de
State New
Headers show
Series
  • [RESEND2] drm/bridge: analogix-anx6345: Fix drm_dp_link helper removal
Related show

Commit Message

Torsten Duwe Feb. 21, 2020, 2:04 p.m. UTC
drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
and the multiply+divide alltogether.

fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
Signed-off-by: Torsten Duwe <duwe@suse.de>
---
https://patchwork.freedesktop.org/patch/343004/
https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html

Can someone please review this? It's equivalent to commit
3e138a63d6674a4567a018a31 which just made it into drm-tip.

Comments

Thomas Zimmermann Feb. 21, 2020, 2:39 p.m. UTC | #1
Hi Torsten

Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
> and the multiply+divide alltogether.
> 
> fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")

You have to create the fixes tag and related cc tags with 'dim fixes',
available at [1]. For this patch, the output is

Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5")
Cc: Torsten Duwe <duwe@suse.de>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Torsten Duwe <duwe@lst.de>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Icenowy Zheng <icenowy@aosc.io>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>

> Signed-off-by: Torsten Duwe <duwe@suse.de>

You signed off with your SUSE email address, but sent the mail from
lst.de. I don't know if it's strictly not allowed, but that's at least
confusing to the tools.

Best regards
Thomas

[1] https://gitlab.freedesktop.org/drm/maintainer-tools/

> ---
> https://patchwork.freedesktop.org/patch/343004/
> https://lists.freedesktop.org/archives/dri-devel/2020-January/253535.html
> 
> Can someone please review this? It's equivalent to commit
> 3e138a63d6674a4567a018a31 which just made it into drm-tip.
> 
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -210,10 +210,9 @@ static int anx6345_dp_link_training(struct anx6345 *anx6345)
>  	if (err)
>  		return err;
>  
> -	dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd);
> -	dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]);
>  	err = regmap_write(anx6345->map[I2C_IDX_DPTX],
> -			   SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]);
> +			   SP_DP_MAIN_LINK_BW_SET_REG,
> +			   anx6345->dpcd[DP_MAX_LINK_RATE]);
>  	if (err)
>  		return err;
>  
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
Torsten Duwe Feb. 21, 2020, 3:01 p.m. UTC | #2
On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote:
> Hi Torsten
> 
> Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
> > and the multiply+divide alltogether.
> > 
> > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
> 
> You have to create the fixes tag and related cc tags with 'dim fixes',
> available at [1]. For this patch, the output is
> 
> Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5")
> Cc: Torsten Duwe <duwe@suse.de>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Cc: Torsten Duwe <duwe@lst.de>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Icenowy Zheng <icenowy@aosc.io>
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>

Ah, neat.

> > Signed-off-by: Torsten Duwe <duwe@suse.de>
> 
> You signed off with your SUSE email address, but sent the mail from
> lst.de. I don't know if it's strictly not allowed, but that's at least
> confusing to the tools.

From my understanding, it is legally correct. The work is owned by Suse,
so I have to sign off as an employee, but I'm subscribed with the LST
address, and I'd also like to see all replies there.

> [1] https://gitlab.freedesktop.org/drm/maintainer-tools/

I'll send an appropriate v2 once I get a review for it.

Thanks!

	Torsten
Laurent Pinchart Feb. 21, 2020, 3:05 p.m. UTC | #3
Hi Torsten,

On Fri, Feb 21, 2020 at 04:01:17PM +0100, Torsten Duwe wrote:
> On Fri, Feb 21, 2020 at 03:39:32PM +0100, Thomas Zimmermann wrote:
> > Am 21.02.20 um 15:04 schrieb Torsten Duwe:
> > > drm_dp_link_rate_to_bw_code and ...bw_code_to_link_rate simply divide by
> > > and multiply with 27000, respectively. Avoid an overflow in the u8 dpcd[0]
> > > and the multiply+divide alltogether.
> > > 
> > > fixes: e1cff82c1097bda2478 ("fix anx6345 compilation for v5.5")
> > 
> > You have to create the fixes tag and related cc tags with 'dim fixes',
> > available at [1]. For this patch, the output is
> > 
> > Fixes: e1cff82c1097 ("drm/bridge: fix anx6345 compilation for v5.5")
> > Cc: Torsten Duwe <duwe@suse.de>
> > Cc: Maxime Ripard <maxime@cerno.tech>
> > Cc: Torsten Duwe <duwe@lst.de>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Icenowy Zheng <icenowy@aosc.io>
> > Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> 
> Ah, neat.
> 
> > > Signed-off-by: Torsten Duwe <duwe@suse.de>
> > 
> > You signed off with your SUSE email address, but sent the mail from
> > lst.de. I don't know if it's strictly not allowed, but that's at least
> > confusing to the tools.
> 
> From my understanding, it is legally correct. The work is owned by Suse,
> so I have to sign off as an employee, but I'm subscribed with the LST
> address, and I'd also like to see all replies there.

That's fine, but then the mail body should start with a From: line that
matches the address used in Signed-off-by. git-send-email should
generate that automatically.

> > [1] https://gitlab.freedesktop.org/drm/maintainer-tools/
> 
> I'll send an appropriate v2 once I get a review for it.

Patch
diff mbox series

--- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
@@ -210,10 +210,9 @@  static int anx6345_dp_link_training(struct anx6345 *anx6345)
 	if (err)
 		return err;
 
-	dpcd[0] = drm_dp_max_link_rate(anx6345->dpcd);
-	dpcd[0] = drm_dp_link_rate_to_bw_code(dpcd[0]);
 	err = regmap_write(anx6345->map[I2C_IDX_DPTX],
-			   SP_DP_MAIN_LINK_BW_SET_REG, dpcd[0]);
+			   SP_DP_MAIN_LINK_BW_SET_REG,
+			   anx6345->dpcd[DP_MAX_LINK_RATE]);
 	if (err)
 		return err;