[08/11] btrfs: replace u_long type cast with unsigned long
diff mbox series

Message ID f21f18a03a86c32c44e60f9b08d67cc7ff0ea272.1582302545.git.dsterba@suse.com
State New
Headers show
Series
  • Minor cleanups
Related show

Commit Message

David Sterba Feb. 21, 2020, 4:31 p.m. UTC
We don't use the u_XX types anywhere, though they're defined.

Signed-off-by: David Sterba <dsterba@suse.com>
---
 fs/btrfs/volumes.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Johannes Thumshirn Feb. 22, 2020, 8:48 a.m. UTC | #1
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Christoph Hellwig Feb. 24, 2020, 8:09 p.m. UTC | #2
On Fri, Feb 21, 2020 at 05:31:17PM +0100, David Sterba wrote:
> We don't use the u_XX types anywhere, though they're defined.
> 
> Signed-off-by: David Sterba <dsterba@suse.com>
> ---
>  fs/btrfs/volumes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 945b89e2104f..fe1f609c736b 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -6269,8 +6269,8 @@ static void submit_stripe_bio(struct btrfs_bio *bbio, struct bio *bio,
>  	btrfs_debug_in_rcu(fs_info,
>  	"btrfs_map_bio: rw %d 0x%x, sector=%llu, dev=%lu (%s id %llu), size=%u",
>  		bio_op(bio), bio->bi_opf, (u64)bio->bi_iter.bi_sector,
> -		(u_long)dev->bdev->bd_dev, rcu_str_deref(dev->name), dev->devid,
> -		bio->bi_iter.bi_size);
> +		(unsigned long)dev->bdev->bd_dev, rcu_str_deref(dev->name),
> +		dev->devid, bio->bi_iter.bi_size);

Mostly we just print major and minor separately, which would remove the
cast entirely.

Patch
diff mbox series

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 945b89e2104f..fe1f609c736b 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6269,8 +6269,8 @@  static void submit_stripe_bio(struct btrfs_bio *bbio, struct bio *bio,
 	btrfs_debug_in_rcu(fs_info,
 	"btrfs_map_bio: rw %d 0x%x, sector=%llu, dev=%lu (%s id %llu), size=%u",
 		bio_op(bio), bio->bi_opf, (u64)bio->bi_iter.bi_sector,
-		(u_long)dev->bdev->bd_dev, rcu_str_deref(dev->name), dev->devid,
-		bio->bi_iter.bi_size);
+		(unsigned long)dev->bdev->bd_dev, rcu_str_deref(dev->name),
+		dev->devid, bio->bi_iter.bi_size);
 	bio_set_dev(bio, dev->bdev);
 
 	btrfs_bio_counter_inc_noblocked(fs_info);