From patchwork Fri Feb 21 21:02:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11397369 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A8F717EF for ; Fri, 21 Feb 2020 21:03:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79705208C4 for ; Fri, 21 Feb 2020 21:03:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="lgWtJTnY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79705208C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2B8816F51A; Fri, 21 Feb 2020 21:03:45 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 14AD36F51A for ; Fri, 21 Feb 2020 21:03:44 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id n10so3557506wrm.1 for ; Fri, 21 Feb 2020 13:03:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hx/cPuNXkvvRSURKUkq3f2ByH3GR1vkT+hlQK0aAurQ=; b=lgWtJTnY1oKpLYBl4tBjbdfPunguSjv/O93nX20eSIKjR1gk8icMghiTJgqkRPbkaY TzNJFlvNeo+xw39S1tq9bYg+Q7+5YdUpKsP2pjW9TUN0Qrfmv0COm//mml1bByxgsMFb hIit5kAj7OZfGRHwmz9LBbT3ac0zyRRuzH+vI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hx/cPuNXkvvRSURKUkq3f2ByH3GR1vkT+hlQK0aAurQ=; b=bPHVKnTlDr4QKUMaRiL/CnlHN2bZC1MbkzWl/nm9S4PoJF8MDqBT/4XbQKmp6ECsSa vKrKO/sFZVsffuRmyoBLv35jHpjMcEtRryFy5xkJ82T9qgCdtArhjZypi87ZckC2B+n+ QqAUi3ac2ygYRTiIfVnq61aw3MzKdLSJFDtYWggQnSZCasTz82omfrl/z7F9r9iFd8Rr fnYVeZ4ciqspq+oY2faQJJLXGdo5YIsJrhalvEDk4buczmMn//GYgbxxPEFuv2YxTbe+ EZHur7mdrY0bCOIumoxlcHVVpKLJeECgu7So0gt1LTvG7YRkbRTvLscgxKX61X3jCKI7 BisA== X-Gm-Message-State: APjAAAWhzOMUmnvrHv0OQtD5kdHOEBYE+0h7+UsgxRm/Rd3/el0UTqTc TYTcGOWyXDOeq5WCC6paUt14VC8vj8w= X-Google-Smtp-Source: APXvYqyPXqD5RTkDrVwIScLYtEkbJmUxrGSVo6I5yNWlVi4Ye5BD+6+9dj2p1FtB4aQXqUOxNorNIA== X-Received: by 2002:adf:f310:: with SMTP id i16mr51953875wro.326.1582319022469; Fri, 21 Feb 2020 13:03:42 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z6sm5483930wrw.36.2020.02.21.13.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 13:03:41 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 11/51] drm/tidss: Use drmm_add_final_kfree Date: Fri, 21 Feb 2020 22:02:39 +0100 Message-Id: <20200221210319.2245170-12-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> References: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Tomi Valkeinen , Jyri Sarha , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With this we can drop the final kfree from the release function. Signed-off-by: Daniel Vetter Cc: Jyri Sarha Cc: Tomi Valkeinen Acked-by: Jyri Sarha --- drivers/gpu/drm/tidss/tidss_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c index d95e4be2c7b9..32a85628dbec 100644 --- a/drivers/gpu/drm/tidss/tidss_drv.c +++ b/drivers/gpu/drm/tidss/tidss_drv.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include "tidss_dispc.h" @@ -109,8 +110,6 @@ static void tidss_release(struct drm_device *ddev) tidss_modeset_cleanup(tidss); drm_dev_fini(ddev); - - kfree(tidss); } DEFINE_DRM_GEM_CMA_FOPS(tidss_fops); @@ -154,6 +153,7 @@ static int tidss_probe(struct platform_device *pdev) kfree(ddev); return ret; } + drmm_add_final_kfree(ddev, tidss); tidss->dev = dev; tidss->feat = of_device_get_match_data(dev);