From patchwork Fri Feb 21 21:02:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11397433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E36B1580 for ; Fri, 21 Feb 2020 21:04:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57A8C2073A for ; Fri, 21 Feb 2020 21:04:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="ZWSVPHjD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57A8C2073A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D0DD6F531; Fri, 21 Feb 2020 21:04:10 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80F556F525 for ; Fri, 21 Feb 2020 21:03:47 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id w15so3536307wru.4 for ; Fri, 21 Feb 2020 13:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Awh1scCBZDnbimNWmMKzFzKs8NB+SPqvHt1ZzjCLXAI=; b=ZWSVPHjDTuKKPhSfysZ6Gff5Klk5d+PxVqDyQ5CkrTOgcMpVChZO7pvZcXC+LFMHev c11px2SEQSH/7pJkU1HWWHYYB9Nj4eqD2l5vLi6rsCH9Tuct84vMF00zuOUd3eEt93MZ ZArkUPBXTumYewKShaUO/kYM+Wp3lGA5c3BYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Awh1scCBZDnbimNWmMKzFzKs8NB+SPqvHt1ZzjCLXAI=; b=oAU+fSn1lSI3qa2s8+zh7n5nsW6ivXsLF5XkWGAI0EcBbkertsgrsZEvqnJuu7alPW oMf2u+vxPVdPEpd0//LvrGlsZDF7Z4iJMA67+zwkzdcrjcigVZRXDjU3A7stvgqHskVG Y6Q4sIofsGsnkfL5qET5kvJ6Fe1AoHyeBC6CZuZ/7pLjk0/vuC/cl48+vDhowCkQDkfw uWdMiPx8PI5+5+W43fn5EJpGHMOi6TGo+8AxbUAt9N0cwZ8IeUjXeyLXvY69rtsJ7OAf jI0JdXHIgFlCVbXbjZPoZbXFVDvQCWNwFmFCrMDv4QmSo8hm7oxv8G6SymZRMPiyOxUI vcfw== X-Gm-Message-State: APjAAAXk+zo//M4zfk6Vr8ODTldLL2Ke+tNNzEJtoRbZ5U+mFIMk6oN/ 2qJzMnUugg9EhYDP5/dB4MrrR6cpMt0= X-Google-Smtp-Source: APXvYqz1YAgpxDOH1raQBIMQtKlBRNoJqzoBLnIGZ8lcCDJudDScahnP2J4rnUWEbcwt1tbUfvLRoA== X-Received: by 2002:a5d:69cf:: with SMTP id s15mr23003305wrw.184.1582319025487; Fri, 21 Feb 2020 13:03:45 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z6sm5483930wrw.36.2020.02.21.13.03.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2020 13:03:44 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 13/51] drm/vgem: Use drmm_add_final_kfree Date: Fri, 21 Feb 2020 22:02:41 +0100 Message-Id: <20200221210319.2245170-14-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> References: <20200221210319.2245170-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Daniel Vetter , Intel Graphics Development , Sean Paul , Daniel Vetter , Sam Ravnborg , Emil Velikov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" With this we can drop the final kfree from the release function. v2: After drm_dev_init/drmm_add_final_kfree we need to clean up everything through a drm_dev_put. Rework the unwind code to match that. Signed-off-by: Daniel Vetter Cc: Daniel Vetter Cc: Emil Velikov Cc: Chris Wilson Cc: Sean Paul Cc: Eric Anholt Cc: Rob Clark Cc: Sam Ravnborg --- drivers/gpu/drm/vgem/vgem_drv.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 909eba43664a..7486014e9149 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -39,6 +39,7 @@ #include #include #include +#include #include #include "vgem_drv.h" @@ -432,8 +433,6 @@ static void vgem_release(struct drm_device *dev) platform_device_unregister(vgem->platform); drm_dev_fini(&vgem->drm); - - kfree(vgem); } static struct drm_driver vgem_driver = { @@ -489,16 +488,19 @@ static int __init vgem_init(void) &vgem_device->platform->dev); if (ret) goto out_unregister; + drmm_add_final_kfree(&vgem_device->drm, vgem_device); /* Final step: expose the device/driver to userspace */ - ret = drm_dev_register(&vgem_device->drm, 0); + ret = drm_dev_register(&vgem_device->drm, 0); if (ret) - goto out_fini; + goto out_put; return 0; -out_fini: - drm_dev_fini(&vgem_device->drm); +out_put: + drm_dev_put(&vgem_device->drm); + return ret; + out_unregister: platform_device_unregister(vgem_device->platform); out_free: