diff mbox series

[6/8] drm/i915/tgl: Add note to Wa_1607297627

Message ID 20200222020815.50599-6-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/8] drm/i915/tgl: Extend Wa_1409825376 stepping | expand

Commit Message

Souza, Jose Feb. 22, 2020, 2:08 a.m. UTC
Add note about the confliting information in BSpec about this WA.

BSpec: 52890
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Matt Roper Feb. 24, 2020, 4:42 p.m. UTC | #1
On Fri, Feb 21, 2020 at 06:08:13PM -0800, José Roberto de Souza wrote:
> Add note about the confliting information in BSpec about this WA.
> 
> BSpec: 52890
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>

Acked-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_workarounds.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 978a5b051ce9..bc5025c81c4f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1344,9 +1344,13 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
>  			    GEN9_CTX_PREEMPT_REG,
>  			    GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
>  
> -		/* Wa_1607030317:tgl */
> -		/* Wa_1607186500:tgl */
> -		/* Wa_1607297627:tgl */
> +		/*
> +		 * Wa_1607030317:tgl
> +		 * Wa_1607186500:tgl
> +		 * Wa_1607297627:tgl there is 3 entries for this WA on BSpec, 2
> +		 * of then says it is fixed on B0 the other one says it is
> +		 * permanent
> +		 */
>  		wa_masked_en(wal,
>  			     GEN6_RC_SLEEP_PSMI_CONTROL,
>  			     GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |
> -- 
> 2.25.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 978a5b051ce9..bc5025c81c4f 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1344,9 +1344,13 @@  rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 			    GEN9_CTX_PREEMPT_REG,
 			    GEN12_DISABLE_POSH_BUSY_FF_DOP_CG);
 
-		/* Wa_1607030317:tgl */
-		/* Wa_1607186500:tgl */
-		/* Wa_1607297627:tgl */
+		/*
+		 * Wa_1607030317:tgl
+		 * Wa_1607186500:tgl
+		 * Wa_1607297627:tgl there is 3 entries for this WA on BSpec, 2
+		 * of then says it is fixed on B0 the other one says it is
+		 * permanent
+		 */
 		wa_masked_en(wal,
 			     GEN6_RC_SLEEP_PSMI_CONTROL,
 			     GEN12_WAIT_FOR_EVENT_POWER_DOWN_DISABLE |