| Message ID | 20200222190435.11767-4-masahiroy@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] kbuild: fix DT binding schema rule to detect command line changes | expand |
On Sun, Feb 23, 2020 at 4:04 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > The dt_binding_check is added to PHONY, but it is visible only > when $(dtstree) is not empty. So, it is not specified as phony > for ARCH=x86 etc. > > Add it to PHONY outside the ifneq ... endif block. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- Applied with Rob's Ack. > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 102710a9228c..83f9b8f6fbaf 100644 > --- a/Makefile > +++ b/Makefile > @@ -1238,7 +1238,7 @@ ifneq ($(dtstree),) > %.dtb: include/config/kernel.release scripts_dtc > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > -PHONY += dtbs dtbs_install dtbs_check dt_binding_check > +PHONY += dtbs dtbs_install dtbs_check > dtbs dtbs_check: include/config/kernel.release scripts_dtc > $(Q)$(MAKE) $(build)=$(dtstree) > > @@ -1258,6 +1258,7 @@ PHONY += scripts_dtc > scripts_dtc: scripts_basic > $(Q)$(MAKE) $(build)=scripts/dtc > > +PHONY += dt_binding_check > dt_binding_check: scripts_dtc > $(Q)$(MAKE) $(build)=Documentation/devicetree/bindings > > -- > 2.17.1 >
diff --git a/Makefile b/Makefile index 102710a9228c..83f9b8f6fbaf 100644 --- a/Makefile +++ b/Makefile @@ -1238,7 +1238,7 @@ ifneq ($(dtstree),) %.dtb: include/config/kernel.release scripts_dtc $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ -PHONY += dtbs dtbs_install dtbs_check dt_binding_check +PHONY += dtbs dtbs_install dtbs_check dtbs dtbs_check: include/config/kernel.release scripts_dtc $(Q)$(MAKE) $(build)=$(dtstree) @@ -1258,6 +1258,7 @@ PHONY += scripts_dtc scripts_dtc: scripts_basic $(Q)$(MAKE) $(build)=scripts/dtc +PHONY += dt_binding_check dt_binding_check: scripts_dtc $(Q)$(MAKE) $(build)=Documentation/devicetree/bindings
The dt_binding_check is added to PHONY, but it is visible only when $(dtstree) is not empty. So, it is not specified as phony for ARCH=x86 etc. Add it to PHONY outside the ifneq ... endif block. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)