diff mbox series

[3/4] ARM: dts: axp813: Add charger LED

Message ID 20200223131435.681620-4-megous@megous.com (mailing list archive)
State New, archived
Headers show
Series Add support for charger LED for AXP813 and TBS A711 Tablet | expand

Commit Message

Ondřej Jirman Feb. 23, 2020, 1:14 p.m. UTC
PMIC supports charging status indication via a LED. Add support
for it.

Signed-off-by: Ondrej Jirman <megous@megous.com>
---
 arch/arm/boot/dts/axp81x.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Dan Murphy Feb. 25, 2020, 12:56 p.m. UTC | #1
Ondrej

On 2/23/20 7:14 AM, Ondrej Jirman wrote:
> PMIC supports charging status indication via a LED. Add support
> for it.
>
> Signed-off-by: Ondrej Jirman <megous@megous.com>
> ---
>   arch/arm/boot/dts/axp81x.dtsi | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
> index 1dfeeceabf4c3..00b092f94433d 100644
> --- a/arch/arm/boot/dts/axp81x.dtsi
> +++ b/arch/arm/boot/dts/axp81x.dtsi
> @@ -175,4 +175,9 @@ reg_drivevbus: drivevbus {
>   	usb_power_supply: usb-power-supply {
>   		compatible = "x-powers,axp813-usb-power-supply";
>   	};
> +
> +	charger_led: charger-led {
> +		compatible = "x-powers,axp813-charger-led";
> +		status = "disabled";

As I commented before you need to add function and color to this node 
and read it from the driver.  Or you can add them to the over ride for 
the specific use case.

Another question is is this LED only used for charging or can it be 
multi purpose?

Dan


> +	};
>   };
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/axp81x.dtsi b/arch/arm/boot/dts/axp81x.dtsi
index 1dfeeceabf4c3..00b092f94433d 100644
--- a/arch/arm/boot/dts/axp81x.dtsi
+++ b/arch/arm/boot/dts/axp81x.dtsi
@@ -175,4 +175,9 @@  reg_drivevbus: drivevbus {
 	usb_power_supply: usb-power-supply {
 		compatible = "x-powers,axp813-usb-power-supply";
 	};
+
+	charger_led: charger-led {
+		compatible = "x-powers,axp813-charger-led";
+		status = "disabled";
+	};
 };