From patchwork Tue Feb 25 12:33:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 11403533 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA5C113A4 for ; Tue, 25 Feb 2020 12:35:15 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5C6E20CC7 for ; Tue, 25 Feb 2020 12:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="VfSdu3gw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5C6E20CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6ZPO-0002xp-5Z; Tue, 25 Feb 2020 12:33:54 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j6ZPM-0002xk-O2 for xen-devel@lists.xenproject.org; Tue, 25 Feb 2020 12:33:52 +0000 X-Inumbo-ID: 1434f1fc-57cb-11ea-a490-bc764e2007e4 Received: from smtp-fw-9102.amazon.com (unknown [207.171.184.29]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1434f1fc-57cb-11ea-a490-bc764e2007e4; Tue, 25 Feb 2020 12:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1582634033; x=1614170033; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2zcWvrYUpJNW3wb59B1PDmoQniAYTrqFYhv5/JF0Y6E=; b=VfSdu3gw+XC1F8u9WkZ6uGY+/uHAo9KAPvOmtCRBd4Vwxn2U4nj/XjJj JbXczrTweL2Xhau7l3X0kREs0NSAimCWcl6j6oBGf5wZ+IGz6csWHc+KU tywgRgRTRfdOPl3Vyj7iH9hTwDlnTTrcfFX3360xjyCw2ckc3rkO9VM0u I=; IronPort-SDR: aUN6gpk2XP8esq21UP6RBh9oQ0DFICJIW4MIMn4zxT16hjSQUinP8bEodJt2Y2p4Teesmmohvz ojdagaTUI9jA== X-IronPort-AV: E=Sophos;i="5.70,484,1574121600"; d="scan'208";a="27333009" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-57e1d233.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP; 25 Feb 2020 12:33:50 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-57e1d233.us-east-1.amazon.com (Postfix) with ESMTPS id 8A87C1427E6; Tue, 25 Feb 2020 12:33:48 +0000 (UTC) Received: from EX13D32EUC004.ant.amazon.com (10.43.164.121) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1236.3; Tue, 25 Feb 2020 12:33:47 +0000 Received: from EX13MTAUEE002.ant.amazon.com (10.43.62.24) by EX13D32EUC004.ant.amazon.com (10.43.164.121) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 25 Feb 2020 12:33:46 +0000 Received: from u2f063a87eabd5f.cbg10.amazon.com (10.125.106.135) by mail-relay.amazon.com (10.43.62.224) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Tue, 25 Feb 2020 12:33:44 +0000 From: Paul Durrant To: Date: Tue, 25 Feb 2020 12:33:43 +0000 Message-ID: <20200225123343.26619-1-pdurrant@amazon.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Precedence: Bulk Subject: [Xen-devel] [PATCH] libxl: fix build with older glibc X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Paul Durrant , Ian Jackson , Wei Liu Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Commit 2b02882ebbbc "libxl: add infrastructure to track and query 'recent' domids" added a call to clock_gettime() into libxl. The man- page for this states: "Link with -lrt (only for glibc versions before 2.17)." Unfortunately Centos 6 does have an glibc prior to that version, and the libxl Makefile was not updated to add '-lrt' so the build will fail in that environment. This patch simply adds '-lrt' to LIBXL_LIBS unconditionally, as it does no harm in newer environments. Signed-off-by: Paul Durrant Fixes: 2b02882ebbbc ("libxl: add infrastructure to track and query 'recent' domids") Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu Cc: Anthony PERARD --- tools/libxl/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index ed41e4ee3e..69fcf21577 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -24,6 +24,9 @@ LIBXL_LIBS = $(LDLIBS_libxentoollog) $(LDLIBS_libxenevtchn) $(LDLIBS_libxenctrl) ifeq ($(CONFIG_LIBNL),y) LIBXL_LIBS += $(LIBNL3_LIBS) endif +ifeq ($(CONFIG_Linux),y) +LIBXL_LIBS += -lrt +endif CFLAGS_LIBXL += $(CFLAGS_libxentoollog) CFLAGS_LIBXL += $(CFLAGS_libxentoolcore)