[Intel-gfx,03/10] drm/i915/display/ddi: Make MISSING_CASE backtrace i915 specific
diff mbox series

Message ID 20200225134709.6153-4-pankaj.laxminarayan.bharadiya@intel.com
State New
Headers show
Series
  • drm/i915: Introduce i915 based i915_MISSING_CASE macro and us it in i915
Related show

Commit Message

Pankaj Bharadiya Feb. 25, 2020, 1:47 p.m. UTC
i915_MISSING_CASE macro includes the device information in the
backtrace, so we know what device the warnings originate from.

Covert MISSING_CASE calls with i915 specific i915_MISSING_CASE variant
in functions where drm_i915_private struct pointer is readily
available.

The conversion was done automatically with below coccinelle semantic
patch.

@rule1@
identifier func, T;
@@
func(...) {
...
struct drm_i915_private *T = ...;
<...
-MISSING_CASE(
+i915_MISSING_CASE(T,
...)
...>
}

@rule2@
identifier func, T;
@@
func(struct drm_i915_private *T,...) {
<...
-MISSING_CASE(
+i915_MISSING_CASE(T,
...)
...>

}

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 9f7d1d7189ae..e060c5e2fbb1 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -873,7 +873,7 @@  cnl_get_buf_trans_hdmi(struct drm_i915_private *dev_priv, int *n_entries)
 		return cnl_ddi_translations_hdmi_1_05V;
 	} else {
 		*n_entries = 1; /* shut up gcc */
-		MISSING_CASE(voltage);
+		i915_MISSING_CASE(dev_priv, voltage);
 	}
 	return NULL;
 }
@@ -894,7 +894,7 @@  cnl_get_buf_trans_dp(struct drm_i915_private *dev_priv, int *n_entries)
 		return cnl_ddi_translations_dp_1_05V;
 	} else {
 		*n_entries = 1; /* shut up gcc */
-		MISSING_CASE(voltage);
+		i915_MISSING_CASE(dev_priv, voltage);
 	}
 	return NULL;
 }
@@ -916,7 +916,7 @@  cnl_get_buf_trans_edp(struct drm_i915_private *dev_priv, int *n_entries)
 			return cnl_ddi_translations_edp_1_05V;
 		} else {
 			*n_entries = 1; /* shut up gcc */
-			MISSING_CASE(voltage);
+			i915_MISSING_CASE(dev_priv, voltage);
 		}
 		return NULL;
 	} else {
@@ -1360,7 +1360,7 @@  static int hsw_ddi_calc_wrpll_link(struct drm_i915_private *dev_priv,
 		refclk = 2700;
 		break;
 	default:
-		MISSING_CASE(wrpll);
+		i915_MISSING_CASE(dev_priv, wrpll);
 		return 0;
 	}
 
@@ -1500,7 +1500,7 @@  static int icl_calc_tbt_pll_link(struct drm_i915_private *dev_priv,
 	case DDI_CLK_SEL_TBT_810:
 		return 810000;
 	default:
-		MISSING_CASE(val);
+		i915_MISSING_CASE(dev_priv, val);
 		return 0;
 	}
 }
@@ -1553,7 +1553,7 @@  static int icl_calc_mg_pll_link(struct drm_i915_private *dev_priv,
 		div1 = 7;
 		break;
 	default:
-		MISSING_CASE(pll_state->mg_clktop2_hsclkctl);
+		i915_MISSING_CASE(dev_priv, pll_state->mg_clktop2_hsclkctl);
 		return 0;
 	}
 
@@ -1841,7 +1841,7 @@  void intel_ddi_set_dp_msa(const struct intel_crtc_state *crtc_state,
 		temp |= DP_MSA_MISC_12_BPC;
 		break;
 	default:
-		MISSING_CASE(crtc_state->pipe_bpp);
+		i915_MISSING_CASE(dev_priv, crtc_state->pipe_bpp);
 		break;
 	}
 
@@ -2156,7 +2156,8 @@  static void intel_ddi_get_encoder_pipes(struct intel_encoder *encoder,
 
 		switch (tmp & TRANS_DDI_EDP_INPUT_MASK) {
 		default:
-			MISSING_CASE(tmp & TRANS_DDI_EDP_INPUT_MASK);
+			i915_MISSING_CASE(dev_priv,
+					  tmp & TRANS_DDI_EDP_INPUT_MASK);
 			/* fallthrough */
 		case TRANS_DDI_EDP_INPUT_A_ON:
 		case TRANS_DDI_EDP_INPUT_A_ONOFF:
@@ -3334,7 +3335,7 @@  icl_program_mg_dp_mode(struct intel_digital_port *intel_dig_port,
 		}
 		break;
 	default:
-		MISSING_CASE(pin_assignment);
+		i915_MISSING_CASE(dev_priv, pin_assignment);
 	}
 
 	if (INTEL_GEN(dev_priv) >= 12) {