[3/3] libxl: make the top level 'device' node in xenstore writable...
diff mbox series

Message ID 20200226160848.1854-4-pdurrant@amazon.com
State New
Headers show
  • PV driver compatibility fixes
Related show

Commit Message

Paul Durrant Feb. 26, 2020, 4:08 p.m. UTC
... by the guest.

Since this node is created largely to host the frontend areas for PV
devices, all of which are fully guest-writable, there seems little point
in making the top level node read-only. Other toolstacks, such as xend,
did make the node writable by the guest and some PV drivers [1] relied
upon this to stash information.

[1] https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/5/html/para-virtualized_windows_drivers_guide/sect-para-virtualized_windows_drivers_guide-installing_and_configuring_the_para_virtualized_drivers-installing_the_para_virtualized_drivers

Signed-off-by: Paul Durrant <pdurrant@amazon.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wl@xen.org>
Cc: Anthony PERARD <anthony.perard@citrix.com>
 tools/libxl/libxl_create.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 7119e95412..bc8e525821 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -752,7 +752,7 @@  retry_transaction:
                     roperm, ARRAY_SIZE(roperm));
     libxl__xs_mknod(gc, t,
                     GCSPRINTF("%s/device", dom_path),
-                    roperm, ARRAY_SIZE(roperm));
+                    rwperm, ARRAY_SIZE(rwperm));
     libxl__xs_mknod(gc, t,
                     GCSPRINTF("%s/control", dom_path),
                     roperm, ARRAY_SIZE(roperm));