diff mbox series

[v3,01/11] drm/i915/tgl: Implement Wa_1409804808

Message ID 20200227220101.321671-1-jose.souza@intel.com (mailing list archive)
State New, archived
Headers show
Series [v3,01/11] drm/i915/tgl: Implement Wa_1409804808 | expand

Commit Message

Souza, Jose Feb. 27, 2020, 10 p.m. UTC
This workaround the CS not done issue on PIPE_CONTROL.

v2:
- replaced BIT() by REG_BIT() in all GEN7_ROW_CHICKEN2() bits
- shortened the name of the new bit

BSpec: 52890
BSpec: 46218
Cc: Matt Roper <matthew.d.roper@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++++++
 drivers/gpu/drm/i915/i915_reg.h             | 5 +++--
 2 files changed, 9 insertions(+), 2 deletions(-)

Comments

Souza, Jose March 2, 2020, 8:05 p.m. UTC | #1
On Sat, 2020-02-29 at 12:07 +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [v3,01/11] drm/i915/tgl: Implement
> Wa_1409804808
> URL   : https://patchwork.freedesktop.org/series/74044/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_8023_full -> Patchwork_16748_full
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_16748_full absolutely
> need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the
> changes
>   introduced in Patchwork_16748_full, please notify your bug team to
> allow them
>   to document this new failure mode, which will reduce false
> positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in
> Patchwork_16748_full:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@gem_exec_whisper@basic-contexts-forked:
>     - shard-iclb:         [PASS][1] -> [INCOMPLETE][2]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb4/igt@gem_exec_whisper@basic-contexts-forked.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb4/igt@gem_exec_whisper@basic-contexts-forked.html
> 

This patches only apply to TGL so this regression is not related.

Patches reviewed pushed to dinq, thanks for the reviews Matt and
Lionel.


>   
> #### Warnings ####
> 
>   * igt@gem_tiled_wc:
>     - shard-skl:          [TIMEOUT][3] ([i915#1286]) ->
> [INCOMPLETE][4]
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl6/igt@gem_tiled_wc.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl2/igt@gem_tiled_wc.html
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_8023_full and
> Patchwork_16748_full:
> 
> ### New IGT tests (1) ###
> 
>   * igt@kms_selftest@all:
>     - Statuses :
>     - Exec time: [None] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_16748_full that come from
> known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@gem_exec_schedule@implicit-both-bsd:
>     - shard-iclb:         [PASS][5] -> [SKIP][6] ([i915#677]) +1
> similar issue
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb3/igt@gem_exec_schedule@implicit-both-bsd.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb1/igt@gem_exec_schedule@implicit-both-bsd.html
> 
>   * igt@gem_exec_schedule@implicit-both-bsd1:
>     - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109276] /
> [i915#677])
>    [7]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb4/igt@gem_exec_schedule@implicit-both-bsd1.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb5/igt@gem_exec_schedule@implicit-both-bsd1.html
> 
>   * igt@gem_exec_schedule@preempt-other-chain-bsd:
>     - shard-iclb:         [PASS][9] -> [SKIP][10] ([fdo#112146]) +5
> similar issues
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb7/igt@gem_exec_schedule@preempt-other-chain-bsd.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
> 
>   * igt@gem_exec_whisper@basic-fds-forked:
>     - shard-glk:          [PASS][11] -> [INCOMPLETE][12] ([i915#58] /
> [k.org#198133])
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-glk8/igt@gem_exec_whisper@basic-fds-forked.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-glk4/igt@gem_exec_whisper@basic-fds-forked.html
> 
>   * igt@gem_exec_whisper@basic-queues-forked:
>     - shard-apl:          [PASS][13] -> [INCOMPLETE][14]
> ([fdo#103927])
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-apl3/igt@gem_exec_whisper@basic-queues-forked.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-apl4/igt@gem_exec_whisper@basic-queues-forked.html
> 
>   * igt@gem_ppgtt@flink-and-close-vma-leak:
>     - shard-glk:          [PASS][15] -> [FAIL][16] ([i915#644])
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-glk1/igt@gem_ppgtt@flink-and-close-vma-leak.html
>    [16]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-glk5/igt@gem_ppgtt@flink-and-close-vma-leak.html
> 
>   * igt@i915_pm_dc@dc5-dpms:
>     - shard-iclb:         [PASS][17] -> [FAIL][18] ([i915#447])
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb8/igt@i915_pm_dc@dc5-dpms.html
>    [18]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb3/igt@i915_pm_dc@dc5-dpms.html
> 
>   * igt@i915_pm_rps@reset:
>     - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#39])
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-glk3/igt@i915_pm_rps@reset.html
>    [20]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-glk3/igt@i915_pm_rps@reset.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-suspend:
>     - shard-kbl:          [PASS][21] -> [DMESG-WARN][22] ([i915#180])
> +3 similar issues
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible:
>     - shard-skl:          [PASS][23] -> [FAIL][24] ([i915#79])
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
>    [24]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
> 
>   * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite:
>     - shard-tglb:         [PASS][25] -> [SKIP][26] ([i915#668]) +4
> similar issues
>    [25]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-tglb5/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html
>    [26]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-tglb5/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-pwrite.html
> 
>   * igt@kms_hdr@bpc-switch-suspend:
>     - shard-apl:          [PASS][27] -> [DMESG-WARN][28] ([i915#180])
> +2 similar issues
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-apl3/igt@kms_hdr@bpc-switch-suspend.html
>    [28]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-apl4/igt@kms_hdr@bpc-switch-suspend.html
>     - shard-skl:          [PASS][29] -> [FAIL][30] ([i915#1188]) +1
> similar issue
>    [29]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
> 
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
>     - shard-skl:          [PASS][31] -> [FAIL][32] ([fdo#108145] /
> [i915#265])
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
> 
>   * igt@perf_pmu@busy-vcs1:
>     - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#112080]) +13
> similar issues
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb1/igt@perf_pmu@busy-vcs1.html
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb5/igt@perf_pmu@busy-vcs1.html
> 
>   * igt@prime_vgem@fence-wait-bsd2:
>     - shard-iclb:         [PASS][35] -> [SKIP][36] ([fdo#109276]) +22
> similar issues
>    [35]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb5/igt@prime_vgem@fence-wait-bsd2.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_ctx_persistence@legacy-engines-mixed-process@blt:
>     - shard-skl:          [INCOMPLETE][37] ([i915#1197] /
> [i915#1239]) -> [PASS][38]
>    [37]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl5/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
>    [38]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl9/igt@gem_ctx_persistence@legacy-engines-mixed-process@blt.html
> 
>   * igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1:
>     - shard-skl:          [FAIL][39] ([i915#679]) -> [PASS][40]
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl5/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
>    [40]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl9/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd1.html
> 
>   * {igt@gem_ctx_ringsize@active@bcs0}:
>     - shard-iclb:         [INCOMPLETE][41] ([i915#1333]) ->
> [PASS][42]
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb1/igt@gem_ctx_ringsize@active@bcs0.html
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb5/igt@gem_ctx_ringsize@active@bcs0.html
> 
>   * igt@gem_exec_schedule@implicit-read-write-bsd1:
>     - shard-iclb:         [SKIP][43] ([fdo#109276] / [i915#677]) ->
> [PASS][44] +2 similar issues
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb6/igt@gem_exec_schedule@implicit-read-write-bsd1.html
>    [44]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb4/igt@gem_exec_schedule@implicit-read-write-bsd1.html
> 
>   * igt@gem_exec_schedule@preempt-queue-bsd:
>     - shard-iclb:         [SKIP][45] ([fdo#112146]) -> [PASS][46] +4
> similar issues
>    [45]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd.html
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb6/igt@gem_exec_schedule@preempt-queue-bsd.html
> 
>   * igt@gem_exec_whisper@basic-contexts-forked:
>     - shard-apl:          [INCOMPLETE][47] ([fdo#103927]) ->
> [PASS][48] +1 similar issue
>    [47]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-apl2/igt@gem_exec_whisper@basic-contexts-forked.html
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-apl3/igt@gem_exec_whisper@basic-contexts-forked.html
> 
>   * igt@gem_userptr_blits@sync-unmap-after-close:
>     - shard-glk:          [DMESG-WARN][49] ([fdo#111870] /
> [i915#836]) -> [PASS][50]
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-glk1/igt@gem_userptr_blits@sync-unmap-after-close.html
>    [50]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-glk5/igt@gem_userptr_blits@sync-unmap-after-close.html
> 
>   * igt@gem_workarounds@suspend-resume-context:
>     - shard-apl:          [DMESG-WARN][51] ([i915#180]) -> [PASS][52]
> +3 similar issues
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-apl6/igt@gem_workarounds@suspend-resume-context.html
>    [52]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-apl7/igt@gem_workarounds@suspend-resume-context.html
> 
>   * igt@i915_pm_dc@dc6-dpms:
>     - shard-iclb:         [INCOMPLETE][53] -> [PASS][54]
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb2/igt@i915_pm_dc@dc6-dpms.html
>    [54]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-iclb:         [FAIL][55] ([i915#454]) -> [PASS][56]
>    [55]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb2/igt@i915_pm_dc@dc6-psr.html
> 
>   * igt@i915_pm_rps@waitboost:
>     - shard-tglb:         [FAIL][57] ([i915#413]) -> [PASS][58]
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-tglb6/igt@i915_pm_rps@waitboost.html
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-tglb8/igt@i915_pm_rps@waitboost.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
>     - shard-skl:          [FAIL][59] ([i915#54]) -> [PASS][60]
>    [59]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html
>    [60]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
>     - shard-apl:          [FAIL][61] ([i915#54]) -> [PASS][62]
>    [61]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
>     - shard-skl:          [FAIL][63] ([IGT#5]) -> [PASS][64]
>    [63]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
>    [64]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-suspend:
>     - shard-kbl:          [DMESG-WARN][65] ([i915#180]) -> [PASS][66]
> +2 similar issues
>    [65]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
>    [66]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html
> 
>   * igt@kms
> _frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
>     - shard-skl:          [FAIL][67] ([i915#49]) -> [PASS][68]
>    [67]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
> 
>   * igt@kms_psr@psr2_cursor_mmap_gtt:
>     - shard-iclb:         [SKIP][69] ([fdo#109441]) -> [PASS][70]
>    [69]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_gtt.html
>    [70]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
> 
>   * igt@perf_pmu@busy-accuracy-2-vcs1:
>     - shard-iclb:         [SKIP][71] ([fdo#112080]) -> [PASS][72] +14
> similar issues
>    [71]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb3/igt@perf_pmu@busy-accuracy-2-vcs1.html
>    [72]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb1/igt@perf_pmu@busy-accuracy-2-vcs1.html
> 
>   * igt@prime_busy@hang-bsd2:
>     - shard-iclb:         [SKIP][73] ([fdo#109276]) -> [PASS][74] +14
> similar issues
>    [73]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb6/igt@prime_busy@hang-bsd2.html
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb2/igt@prime_busy@hang-bsd2.html
> 
>   
> #### Warnings ####
> 
>   * igt@gem_ctx_isolation@vcs1-nonpriv:
>     - shard-iclb:         [SKIP][75] ([fdo#112080]) -> [FAIL][76]
> ([IGT#28])
>    [75]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
> 
>   * igt@i915_pm_dc@dc6-psr:
>     - shard-tglb:         [SKIP][77] ([i915#468]) -> [FAIL][78]
> ([i915#454])
>    [77]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-tglb2/igt@i915_pm_dc@dc6-psr.html
>    [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-tglb1/igt@i915_pm_dc@dc6-psr.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank:
>     - shard-skl:          [FAIL][79] ([i915#46]) -> [FAIL][80]
> ([i915#79])
>    [79]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8023/shard-skl10/igt@kms_flip@flip-vs-expired-vblank.html
>    [80]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/shard-skl2/igt@kms_flip@flip-vs-expired-vblank.html
> 
>   
>   {name}: This element is suppressed. This means it is ignored when
> computing
>           the status of the difference (SUCCESS, WARNING, or
> FAILURE).
> 
>   [IGT#28]: 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
>   [IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
>   [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
>   [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
>   [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
>   [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
>   [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
>   [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
>   [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
>   [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
>   [i915#1197]: https://gitlab.freedesktop.org/drm/intel/issues/1197
>   [i915#1239]: https://gitlab.freedesktop.org/drm/intel/issues/1239
>   [i915#1286]: https://gitlab.freedesktop.org/drm/intel/issues/1286
>   [i915#1333]: https://gitlab.freedesktop.org/drm/intel/issues/1333
>   [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
>   [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
>   [i915#39]: https://gitlab.freedesktop.org/drm/intel/issues/39
>   [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
>   [i915#447]: https://gitlab.freedesktop.org/drm/intel/issues/447
>   [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
>   [i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
>   [i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
>   [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
>   [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
>   [i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
>   [i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
>   [i915#668]: https://gitlab.freedesktop.org/drm/intel/issues/668
>   [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
>   [i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
>   [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
>   [i915#836]: https://gitlab.freedesktop.org/drm/intel/issues/836
>   [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
> 
> 
> Participating hosts (10 -> 10)
> ------------------------------
> 
>   No changes in participating hosts
> 
> 
> Build changes
> -------------
> 
>   * CI: CI-20190529 -> None
>   * Linux: CI_DRM_8023 -> Patchwork_16748
> 
>   CI-20190529: 20190529
>   CI_DRM_8023: fa9a02bbdfd6553ee633171f23183a115d0da577 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_5474: 1be610f852de155cd915e7cda65cb2737adf04d4 @
> git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>   Patchwork_16748: 3f9899a578a87f633e207f2c7fa80bdc04309132 @
> git://anongit.freedesktop.org/gfx-ci/linux
>   piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @
> git://anongit.freedesktop.org/piglit
> 
> == Logs ==
> 
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16748/index.html
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 06cef3c18f26..d402b8ebc780 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1362,6 +1362,12 @@  rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
 			     GEN12_DISABLE_EARLY_READ);
 	}
 
+	if (IS_TIGERLAKE(i915)) {
+		/* Wa_1409804808:tgl */
+		wa_masked_en(wal, GEN7_ROW_CHICKEN2,
+			     GEN12_PUSH_CONST_DEREF_HOLD_DIS);
+	}
+
 	if (IS_GEN(i915, 11)) {
 		/* This is not an Wa. Enable for better image quality */
 		wa_masked_en(wal,
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 72de9591f77f..acace016d46c 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -9140,8 +9140,9 @@  enum {
 #define   THROTTLE_12_5				(7 << 2)
 #define   DISABLE_EARLY_EOT			(1 << 1)
 
-#define GEN7_ROW_CHICKEN2		_MMIO(0xe4f4)
-#define GEN12_DISABLE_EARLY_READ	BIT(14)
+#define GEN7_ROW_CHICKEN2			_MMIO(0xe4f4)
+#define   GEN12_DISABLE_EARLY_READ		REG_BIT(14)
+#define   GEN12_PUSH_CONST_DEREF_HOLD_DIS	REG_BIT(8)
 
 #define GEN7_ROW_CHICKEN2_GT2		_MMIO(0xf4f4)
 #define   DOP_CLOCK_GATING_DISABLE	(1 << 0)