thermal: exynos: Silence warning during deferred probe
diff mbox series

Message ID 20200228092331.21548-1-m.szyprowski@samsung.com
State Not Applicable
Headers show
Series
  • thermal: exynos: Silence warning during deferred probe
Related show

Commit Message

Marek Szyprowski Feb. 28, 2020, 9:23 a.m. UTC
Don't confuse user with meaningless warning about the failure of
registering sensors in case of deferred probe.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Amit Kucheria Feb. 28, 2020, 10:06 a.m. UTC | #1
On Fri, Feb 28, 2020 at 2:53 PM Marek Szyprowski
<m.szyprowski@samsung.com> wrote:
>
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  drivers/thermal/samsung/exynos_tmu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>                                                     &exynos_sensor_ops);
>         if (IS_ERR(data->tzd)) {
>                 ret = PTR_ERR(data->tzd);
> -               dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> +               if (ret != -EPROBE_DEFER)
> +                       dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> +                               ret);
>                 goto err_sclk;
>         }
>
> --
> 2.17.1
>
Bartlomiej Zolnierkiewicz Feb. 28, 2020, 10:29 a.m. UTC | #2
On 2/28/20 10:23 AM, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/thermal/samsung/exynos_tmu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>  						    &exynos_sensor_ops);
>  	if (IS_ERR(data->tzd)) {
>  		ret = PTR_ERR(data->tzd);
> -		dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> +				ret);
>  		goto err_sclk;
>  	}
>
Krzysztof Kozlowski Feb. 28, 2020, 11:30 a.m. UTC | #3
On Fri, Feb 28, 2020 at 10:23:31AM +0100, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  drivers/thermal/samsung/exynos_tmu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Daniel Lezcano March 12, 2020, 10:57 a.m. UTC | #4
On 28/02/2020 10:23, Marek Szyprowski wrote:
> Don't confuse user with meaningless warning about the failure of
> registering sensors in case of deferred probe.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

Applied, thanks

> ---
>  drivers/thermal/samsung/exynos_tmu.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index fd4a17812f33..e9a90bc23b11 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -1094,7 +1094,9 @@ static int exynos_tmu_probe(struct platform_device *pdev)
>  						    &exynos_sensor_ops);
>  	if (IS_ERR(data->tzd)) {
>  		ret = PTR_ERR(data->tzd);
> -		dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "Failed to register sensor: %d\n",
> +				ret);
>  		goto err_sclk;
>  	}
>  
>

Patch
diff mbox series

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index fd4a17812f33..e9a90bc23b11 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -1094,7 +1094,9 @@  static int exynos_tmu_probe(struct platform_device *pdev)
 						    &exynos_sensor_ops);
 	if (IS_ERR(data->tzd)) {
 		ret = PTR_ERR(data->tzd);
-		dev_err(&pdev->dev, "Failed to register sensor: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(&pdev->dev, "Failed to register sensor: %d\n",
+				ret);
 		goto err_sclk;
 	}