[v2,4/4] libselinux: drop symbols from map
diff mbox series

Message ID 20200228140524.2404-5-william.c.roberts@intel.com
State Superseded
Headers show
Series
  • [v2,1/4] dso: drop hidden_proto and hidden_def
Related show

Commit Message

William Roberts Feb. 28, 2020, 2:05 p.m. UTC
From: William Roberts <william.c.roberts@intel.com>

Previously, libselinux was exporting the following symbols:
  - dir_xattr_list;
  - myprintf_compat;
  - unmap_class;
  - unmap_perm;

However, these appear to be unused and can safely be dropped.

This is done as a seperate commit to so it can easily be reverted
seperately for any reasons.

Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
 libselinux/src/libselinux.map | 4 ----
 1 file changed, 4 deletions(-)

Comments

Stephen Smalley Feb. 28, 2020, 3:39 p.m. UTC | #1
On Fri, Feb 28, 2020 at 9:05 AM <bill.c.roberts@gmail.com> wrote:
>
> From: William Roberts <william.c.roberts@intel.com>
>
> Previously, libselinux was exporting the following symbols:
>   - dir_xattr_list;
>   - myprintf_compat;
>   - unmap_class;
>   - unmap_perm;

I had also suggested removing map_class, map_decision, map_perm.
William Roberts Feb. 28, 2020, 3:40 p.m. UTC | #2
On Fri, Feb 28, 2020 at 9:38 AM Stephen Smalley
<stephen.smalley.work@gmail.com> wrote:
>
> On Fri, Feb 28, 2020 at 9:05 AM <bill.c.roberts@gmail.com> wrote:
> >
> > From: William Roberts <william.c.roberts@intel.com>
> >
> > Previously, libselinux was exporting the following symbols:
> >   - dir_xattr_list;
> >   - myprintf_compat;
> >   - unmap_class;
> >   - unmap_perm;
>
> I had also suggested removing map_class, map_decision, map_perm.

Yes you did, I can't believe I skipped over them.

Patch
diff mbox series

diff --git a/libselinux/src/libselinux.map b/libselinux/src/libselinux.map
index 73f4c072af02..31342ca6b58a 100644
--- a/libselinux/src/libselinux.map
+++ b/libselinux/src/libselinux.map
@@ -37,7 +37,6 @@  LIBSELINUX_1.0 {
     context_type_set;
     context_user_get;
     context_user_set;
-    dir_xattr_list;
     fgetfilecon;
     fgetfilecon_raw;
     fini_selinuxmnt;
@@ -94,7 +93,6 @@  LIBSELINUX_1.0 {
     matchpathcon_init;
     matchpathcon_init_prefix;
     mode_to_security_class;
-    myprintf_compat;
     print_access_vector;
     query_user_context;
     realpath_not_final;
@@ -242,8 +240,6 @@  LIBSELINUX_1.0 {
     sidput;
     string_to_av_perm;
     string_to_security_class;
-    unmap_class;
-    unmap_perm;
   local:
     *;
 };