| Message ID | 20200229204527.143796-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
| Series | thermal: Rephrase the Kconfig text for thermal | expand |
On 29/02/2020 21:45, Linus Walleij wrote: > The thermal subsystem may have relied on sysfs in 2008 when it > was introduced, but these days the thermal zones will more often > than not come from the hardware descriptions and not from sysfs. > > Drop the "Generic" phrases as well: there are no non-generic > drivers that I know of, the thermal framework is by definition > generic. > > Reword a bit and fix some grammar. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Thanks for this change :) > --- > drivers/thermal/Kconfig | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 5a05db5438d6..a88aa0f6c5a8 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -1,17 +1,18 @@ > # SPDX-License-Identifier: GPL-2.0-only > # > -# Generic thermal sysfs drivers configuration > +# Generic thermal drivers configuration > # > > menuconfig THERMAL > - bool "Generic Thermal sysfs driver" > + bool "Thermal drivers" > help > - Generic Thermal Sysfs driver offers a generic mechanism for > + Thermal drivers offers a generic mechanism for > thermal management. Usually it's made up of one or more thermal > - zone and cooling device. > + zones and cooling devices. > Each thermal zone contains its own temperature, trip points, > - cooling devices. > - All platforms with ACPI thermal support can use this driver. > + and cooling devices. > + All platforms with ACPI or Open Firmware thermal support can use > + this driver. > If you want this support, you should say Y here. > > if THERMAL >
On 2/29/20 12:45 PM, Linus Walleij wrote: > The thermal subsystem may have relied on sysfs in 2008 when it > was introduced, but these days the thermal zones will more often > than not come from the hardware descriptions and not from sysfs. > > Drop the "Generic" phrases as well: there are no non-generic > drivers that I know of, the thermal framework is by definition > generic. > > Reword a bit and fix some grammar. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/thermal/Kconfig | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 5a05db5438d6..a88aa0f6c5a8 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -1,17 +1,18 @@ > # SPDX-License-Identifier: GPL-2.0-only > # > -# Generic thermal sysfs drivers configuration > +# Generic thermal drivers configuration > # > > menuconfig THERMAL > - bool "Generic Thermal sysfs driver" > + bool "Thermal drivers" > help > - Generic Thermal Sysfs driver offers a generic mechanism for > + Thermal drivers offers a generic mechanism for preferably: offer > thermal management. Usually it's made up of one or more thermal > - zone and cooling device. > + zones and cooling devices.
On Sun, Mar 1, 2020 at 2:17 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > The thermal subsystem may have relied on sysfs in 2008 when it > was introduced, but these days the thermal zones will more often > than not come from the hardware descriptions and not from sysfs. > > Drop the "Generic" phrases as well: there are no non-generic > drivers that I know of, the thermal framework is by definition > generic. > > Reword a bit and fix some grammar. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > drivers/thermal/Kconfig | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 5a05db5438d6..a88aa0f6c5a8 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -1,17 +1,18 @@ > # SPDX-License-Identifier: GPL-2.0-only > # > -# Generic thermal sysfs drivers configuration > +# Generic thermal drivers configuration > # > > menuconfig THERMAL > - bool "Generic Thermal sysfs driver" > + bool "Thermal drivers" > help > - Generic Thermal Sysfs driver offers a generic mechanism for > + Thermal drivers offers a generic mechanism for > thermal management. Usually it's made up of one or more thermal > - zone and cooling device. > + zones and cooling devices. > Each thermal zone contains its own temperature, trip points, > - cooling devices. > - All platforms with ACPI thermal support can use this driver. > + and cooling devices. > + All platforms with ACPI or Open Firmware thermal support can use > + this driver. > If you want this support, you should say Y here. > > if THERMAL > -- > 2.24.1 >
On 29/02/2020 21:45, Linus Walleij wrote: > The thermal subsystem may have relied on sysfs in 2008 when it > was introduced, but these days the thermal zones will more often > than not come from the hardware descriptions and not from sysfs. > > Drop the "Generic" phrases as well: there are no non-generic > drivers that I know of, the thermal framework is by definition > generic. > > Reword a bit and fix some grammar. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> I've applied the patch and fixed Randy's comment Thanks -- Daniel
diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 5a05db5438d6..a88aa0f6c5a8 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -1,17 +1,18 @@ # SPDX-License-Identifier: GPL-2.0-only # -# Generic thermal sysfs drivers configuration +# Generic thermal drivers configuration # menuconfig THERMAL - bool "Generic Thermal sysfs driver" + bool "Thermal drivers" help - Generic Thermal Sysfs driver offers a generic mechanism for + Thermal drivers offers a generic mechanism for thermal management. Usually it's made up of one or more thermal - zone and cooling device. + zones and cooling devices. Each thermal zone contains its own temperature, trip points, - cooling devices. - All platforms with ACPI thermal support can use this driver. + and cooling devices. + All platforms with ACPI or Open Firmware thermal support can use + this driver. If you want this support, you should say Y here. if THERMAL
The thermal subsystem may have relied on sysfs in 2008 when it was introduced, but these days the thermal zones will more often than not come from the hardware descriptions and not from sysfs. Drop the "Generic" phrases as well: there are no non-generic drivers that I know of, the thermal framework is by definition generic. Reword a bit and fix some grammar. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/thermal/Kconfig | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)