From patchwork Mon Mar 2 11:43:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kon5t X-Patchwork-Id: 11415379 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9E47138D for ; Mon, 2 Mar 2020 11:46:45 +0000 (UTC) Received: from bastion.fedoraproject.org (bastion01.fedoraproject.org [209.132.181.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D14214DB for ; Mon, 2 Mar 2020 11:46:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D14214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=libteam-bounces@lists.fedorahosted.org Received: from mailman01.phx2.fedoraproject.org (mailman01.phx2.fedoraproject.org [10.5.126.36]) by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id 95BA36076D11; Mon, 2 Mar 2020 11:46:44 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 bastion01.phx2.fedoraproject.org 95BA36076D11 Received: from mailman01.phx2.fedoraproject.org (localhost [IPv6:::1]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id 81EB15CE349EC; Mon, 2 Mar 2020 11:46:44 +0000 (UTC) Received: by mailman01.phx2.fedoraproject.org (Postfix, from userid 991) id D0D505CE349EA; Mon, 2 Mar 2020 11:46:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mailman01.phx2.fedoraproject.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=disabled version=3.4.0 Received: from smtp-mm-ib01.fedoraproject.org (smtp-mm-ib01.vpn.fedoraproject.org [192.168.1.83]) by mailman01.phx2.fedoraproject.org (Postfix) with ESMTP id 61C615CE349E4 for ; Mon, 2 Mar 2020 11:46:39 +0000 (UTC) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by smtp-mm-ib01.fedoraproject.org (Postfix) with ESMTPS id C68C1605D2E0 for ; Mon, 2 Mar 2020 11:46:38 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id e3so11368587lja.10 for ; Mon, 02 Mar 2020 03:46:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IQgrjCfRDbNpaoZ+CKwQ2r/Z6SlL0qTd7pkGSbqxHOY=; b=QuQkj2gOy3o4WYoCRIkac4d6Ey5NFHdBNyaPwWsFUwFKNjTvoefULAmp3UWcwZ4yIS m9c0l2Kt7W3mqjAQrPRxndT+JFnTj7aFFsErEEi+BXSfnAN1ojQB2JRIlY5JvPouFB9U U4kD4i6/D+GQ8r/L75IrEFaSv1DAe3ExzsnwRj/XVrH4CNFjbOTHbxGluvqtTL+7MROx Sa6b4WQg14DGIIcI2OPXlbadKm1gccG+SaOuE8eqh9tPHzezucDUS1JY6372vLzEukoP lSArunlHjn1td1lFhjOmWKXPRzoTR88fTrpnan/+YDF/ptAaCzuQgk3Xv/8N+K6LRRqn 8X7A== X-Gm-Message-State: ANhLgQ1LoifoMoFUPL2rq1YRalvPAH9NQXgQOvqJb7ZsMmoRLz49lZvH Ioxu35qgrz9Gtv6sSZRlPUadFMrSNW8= X-Google-Smtp-Source: ADFU+vv2yehVA4ul7bVjOZDcFeYpZFtj8JdKHJWgeF8bIbLGJhxHbZLu66obU5fMBZbx4enpBYeTIA== X-Received: by 2002:a2e:984e:: with SMTP id e14mr10920218ljj.88.1583149597195; Mon, 02 Mar 2020 03:46:37 -0800 (PST) Received: from ko-comp.mrn.ru ([46.146.202.208]) by smtp.gmail.com with ESMTPSA id f4sm11077251ljo.79.2020.03.02.03.46.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Mar 2020 03:46:36 -0800 (PST) From: kon5t To: libteam@lists.fedorahosted.org Subject: [patch libteam] teamd/lacp: fix incorrect aggregator selection Date: Mon, 2 Mar 2020 16:43:08 +0500 Message-Id: <1583149388-30061-1-git-send-email-konst.ru@gmail.com> X-Mailer: git-send-email 2.7.4 Message-ID-Hash: 5LISGHXFYJHZWZNFCXI3BBWSC4BNL7OS X-Message-ID-Hash: 5LISGHXFYJHZWZNFCXI3BBWSC4BNL7OS X-MailFrom: konst.ru@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: jiri@resnulli.us, kon5t X-Mailman-Version: 3.1.1 Precedence: list List-Id: Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 No need to `ntohs` values when comparing bytes. Signed-off-by: kon5t --- teamd/teamd_runner_lacp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/teamd/teamd_runner_lacp.c b/teamd/teamd_runner_lacp.c index ec01237..709008e 100644 --- a/teamd/teamd_runner_lacp.c +++ b/teamd/teamd_runner_lacp.c @@ -406,10 +406,7 @@ static void get_lacp_port_prio_info(struct lacp_port *lacp_port, *prio_info = lacp_port->partner; /* adjust values for further memcmp comparison */ - prio_info->system_priority = ntohs(prio_info->system_priority); prio_info->key = 0; - prio_info->port_priority = ntohs(prio_info->port_priority); - prio_info->port = ntohs(prio_info->port); prio_info->state = 0; }