| Message ID | 20200302125649.61443-5-pankaj.laxminarayan.bharadiya@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: drm_fb_helper cleanup. | expand |
On Mon, Mar 2, 2020 at 8:09 AM Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote: > > drm_fb_helper_{add,remove}_one_connector() are dummy functions now > and serve no purpose. Hence remove their calls. > > This is the preparatory step for removing the > drm_fb_helper_{add,remove}_one_connector() functions from > drm_fb_helper.h > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c > index d7bfa7c350e9..b15404a3b1ca 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c > @@ -721,27 +721,15 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo > > static void intel_dp_register_mst_connector(struct drm_connector *connector) > { > - struct drm_i915_private *dev_priv = to_i915(connector->dev); > - > - if (dev_priv->fbdev) > - drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, > - connector); > - > drm_connector_register(connector); > } > > static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, > struct drm_connector *connector) > { > - struct drm_i915_private *dev_priv = to_i915(connector->dev); > - > DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); > drm_connector_unregister(connector); > > - if (dev_priv->fbdev) > - drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, > - connector); > - > drm_connector_put(connector); > } > > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c index d7bfa7c350e9..b15404a3b1ca 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c @@ -721,27 +721,15 @@ static struct drm_connector *intel_dp_add_mst_connector(struct drm_dp_mst_topolo static void intel_dp_register_mst_connector(struct drm_connector *connector) { - struct drm_i915_private *dev_priv = to_i915(connector->dev); - - if (dev_priv->fbdev) - drm_fb_helper_add_one_connector(&dev_priv->fbdev->helper, - connector); - drm_connector_register(connector); } static void intel_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr, struct drm_connector *connector) { - struct drm_i915_private *dev_priv = to_i915(connector->dev); - DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); drm_connector_unregister(connector); - if (dev_priv->fbdev) - drm_fb_helper_remove_one_connector(&dev_priv->fbdev->helper, - connector); - drm_connector_put(connector); }
drm_fb_helper_{add,remove}_one_connector() are dummy functions now and serve no purpose. Hence remove their calls. This is the preparatory step for removing the drm_fb_helper_{add,remove}_one_connector() functions from drm_fb_helper.h Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 12 ------------ 1 file changed, 12 deletions(-)