| Message ID | 20200302125649.61443-9-pankaj.laxminarayan.bharadiya@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: drm_fb_helper cleanup. | expand |
Hi Pankaj, Thank you for the patch. On Mon, Mar 02, 2020 at 06:26:48PM +0530, Pankaj Bharadiya wrote: > drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() > and drm_fb_helper_remove_one_connector() doesn't keep an array of s/doesn't/don't/ > connectors anymore and are just dummy. Now we have no callers to these > functions hence remove them. > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> I like this :-) Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > include/drm/drm_fb_helper.h | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 62e8dda6d1d1..208dbf87afa3 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) > > #endif > > -/* TODO: There's a todo entry to remove these three */ > -static inline int > -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > /** > * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers > * @a: memory range, users of which are to be removed
On Mon, Mar 2, 2020 at 8:09 AM Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> wrote: > > drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() > and drm_fb_helper_remove_one_connector() doesn't keep an array of > connectors anymore and are just dummy. Now we have no callers to these > functions hence remove them. > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > include/drm/drm_fb_helper.h | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h > index 62e8dda6d1d1..208dbf87afa3 100644 > --- a/include/drm/drm_fb_helper.h > +++ b/include/drm/drm_fb_helper.h > @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) > > #endif > > -/* TODO: There's a todo entry to remove these three */ > -static inline int > -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > -static inline int > -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, > - struct drm_connector *connector) > -{ > - return 0; > -} > - > /** > * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers > * @a: memory range, users of which are to be removed > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h index 62e8dda6d1d1..208dbf87afa3 100644 --- a/include/drm/drm_fb_helper.h +++ b/include/drm/drm_fb_helper.h @@ -451,27 +451,6 @@ drm_fbdev_generic_setup(struct drm_device *dev, unsigned int preferred_bpp) #endif -/* TODO: There's a todo entry to remove these three */ -static inline int -drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) -{ - return 0; -} - -static inline int -drm_fb_helper_add_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - -static inline int -drm_fb_helper_remove_one_connector(struct drm_fb_helper *fb_helper, - struct drm_connector *connector) -{ - return 0; -} - /** * drm_fb_helper_remove_conflicting_framebuffers - remove firmware-configured framebuffers * @a: memory range, users of which are to be removed
drm_fb_helper_single_add_all_connectors(), drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector() doesn't keep an array of connectors anymore and are just dummy. Now we have no callers to these functions hence remove them. Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> --- include/drm/drm_fb_helper.h | 21 --------------------- 1 file changed, 21 deletions(-)