[9/9] drm/todo: Update drm_fb_helper tasks
diff mbox series

Message ID 20200302125649.61443-10-pankaj.laxminarayan.bharadiya@intel.com
State New
Headers show
Series
  • drm: drm_fb_helper cleanup.
Related show

Commit Message

Laxminarayan Bharadiya, Pankaj March 2, 2020, 12:56 p.m. UTC
Remove completed drm_fb_helper tasks from todo list.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
 Documentation/gpu/todo.rst | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

Comments

Laurent Pinchart March 2, 2020, 1:29 p.m. UTC | #1
Hi Pankaj,

Thank you for the patch.

On Mon, Mar 02, 2020 at 06:26:49PM +0530, Pankaj Bharadiya wrote:
> Remove completed drm_fb_helper tasks from todo list.
> 
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> ---
>  Documentation/gpu/todo.rst | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index ccf5e8e34222..98d8782e1440 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -362,17 +362,10 @@ Level: Starter
>  drm_fb_helper tasks
>  -------------------
>  
> -- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> -  not the _force variant so it can bail out if there is a master. But first
> -  these igt tests need to be fixed: kms_fbcon_fbt@psr and
> -  kms_fbcon_fbt@psr-suspend.
> -
> -- The max connector argument for drm_fb_helper_init() isn't used anymore and
> -  can be removed.
> -
> -- The helper doesn't keep an array of connectors anymore so these can be
> -  removed: drm_fb_helper_single_add_all_connectors(),
> -  drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
> +drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> +not the _force variant so it can bail out if there is a master. But first
> +these igt tests need to be fixed: kms_fbcon_fbt@psr and
> +kms_fbcon_fbt@psr-suspend.

No need to reflow, you can keep the first list entry as-is and just
remove the next two. With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  Level: Intermediate
>
Daniel Vetter March 2, 2020, 9:35 p.m. UTC | #2
On Mon, Mar 02, 2020 at 03:29:42PM +0200, Laurent Pinchart wrote:
> Hi Pankaj,
> 
> Thank you for the patch.
> 
> On Mon, Mar 02, 2020 at 06:26:49PM +0530, Pankaj Bharadiya wrote:
> > Remove completed drm_fb_helper tasks from todo list.
> > 
> > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
> > ---
> >  Documentation/gpu/todo.rst | 15 ++++-----------
> >  1 file changed, 4 insertions(+), 11 deletions(-)
> > 
> > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> > index ccf5e8e34222..98d8782e1440 100644
> > --- a/Documentation/gpu/todo.rst
> > +++ b/Documentation/gpu/todo.rst
> > @@ -362,17 +362,10 @@ Level: Starter
> >  drm_fb_helper tasks
> >  -------------------
> >  
> > -- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> > -  not the _force variant so it can bail out if there is a master. But first
> > -  these igt tests need to be fixed: kms_fbcon_fbt@psr and
> > -  kms_fbcon_fbt@psr-suspend.
> > -
> > -- The max connector argument for drm_fb_helper_init() isn't used anymore and
> > -  can be removed.
> > -
> > -- The helper doesn't keep an array of connectors anymore so these can be
> > -  removed: drm_fb_helper_single_add_all_connectors(),
> > -  drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
> > +drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
> > +not the _force variant so it can bail out if there is a master. But first
> > +these igt tests need to be fixed: kms_fbcon_fbt@psr and
> > +kms_fbcon_fbt@psr-suspend.

This one here is also done already, see 

commit 64914da24ea95d2b2f7017d014d74c26005d8780
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Feb 4 16:01:43 2020 +0100

    drm/fbdev-helper: don't force restores

So you can delet the entire todo entry completely.

btw would be good to list the patches that fixed the other ones too, if
you can find them quickly in the logfiles.
-Daniel
    
> 
> No need to reflow, you can keep the first list entry as-is and just
> remove the next two. With this fixed,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> >  Level: Intermediate
> >  
> 
> -- 
> Regards,
> 
> Laurent Pinchart

Patch
diff mbox series

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index ccf5e8e34222..98d8782e1440 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -362,17 +362,10 @@  Level: Starter
 drm_fb_helper tasks
 -------------------
 
-- drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
-  not the _force variant so it can bail out if there is a master. But first
-  these igt tests need to be fixed: kms_fbcon_fbt@psr and
-  kms_fbcon_fbt@psr-suspend.
-
-- The max connector argument for drm_fb_helper_init() isn't used anymore and
-  can be removed.
-
-- The helper doesn't keep an array of connectors anymore so these can be
-  removed: drm_fb_helper_single_add_all_connectors(),
-  drm_fb_helper_add_one_connector() and drm_fb_helper_remove_one_connector().
+drm_fb_helper_restore_fbdev_mode_unlocked() should call restore_fbdev_mode()
+not the _force variant so it can bail out if there is a master. But first
+these igt tests need to be fixed: kms_fbcon_fbt@psr and
+kms_fbcon_fbt@psr-suspend.
 
 Level: Intermediate