drm/i915/display: Decrease log level
diff mbox series

Message ID 20200302213807.6488-1-swati2.sharma@intel.com
State New
Headers show
Series
  • drm/i915/display: Decrease log level
Related show

Commit Message

Sharma, Swati2 March 2, 2020, 9:38 p.m. UTC
Converting error to debug print if sink fails to configure scrambling or
TMDS bit clock ratio. In this case, we are timing out while disabling
the scrambling and setting the SCDC ratio, as there is no response
to the I2C SCDC write from the sink device. Error isn't due to something
wrong done from driver side.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Stanislav Lisovskiy March 5, 2020, 8:55 a.m. UTC | #1
On Tue, 2020-03-03 at 03:08 +0530, Swati Sharma wrote:
> Converting error to debug print if sink fails to configure scrambling
> or
> TMDS bit clock ratio. In this case, we are timing out while disabling
> the scrambling and setting the SCDC ratio, as there is no response
> to the I2C SCDC write from the sink device. Error isn't due to
> something
> wrong done from driver side.
> 
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 284219da7df8..457ca88cd277 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3564,8 +3564,9 @@ static void intel_enable_ddi_hdmi(struct
> intel_encoder *encoder,
>  	if (!intel_hdmi_handle_sink_scrambling(encoder, connector,
>  					       crtc_state-
> >hdmi_high_tmds_clock_ratio,
>  					       crtc_state-
> >hdmi_scrambling))
> -		DRM_ERROR("[CONNECTOR:%d:%s] Failed to configure sink
> scrambling/TMDS bit clock ratio\n",
> -			  connector->base.id, connector->name);
> +		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Failed to configure
> sink "
> +			      "scrambling/TMDS bit clock ratio\n",
> +			       connector->base.id, connector->name);
>  
>  	/* Display WA #1143: skl,kbl,cfl */
>  	if (IS_GEN9_BC(dev_priv)) {
Ville Syrjälä March 5, 2020, 1:55 p.m. UTC | #2
On Thu, Mar 05, 2020 at 08:55:31AM +0000, Lisovskiy, Stanislav wrote:
> On Tue, 2020-03-03 at 03:08 +0530, Swati Sharma wrote:
> > Converting error to debug print if sink fails to configure scrambling
> > or
> > TMDS bit clock ratio. In this case, we are timing out while disabling
> > the scrambling and setting the SCDC ratio, as there is no response
> > to the I2C SCDC write from the sink device. Error isn't due to
> > something
> > wrong done from driver side.
> > 
> > Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_ddi.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>

Pushed to dinq. Thanks for the patch and review.

> 
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c
> > b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index 284219da7df8..457ca88cd277 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -3564,8 +3564,9 @@ static void intel_enable_ddi_hdmi(struct
> > intel_encoder *encoder,
> >  	if (!intel_hdmi_handle_sink_scrambling(encoder, connector,
> >  					       crtc_state-
> > >hdmi_high_tmds_clock_ratio,
> >  					       crtc_state-
> > >hdmi_scrambling))
> > -		DRM_ERROR("[CONNECTOR:%d:%s] Failed to configure sink
> > scrambling/TMDS bit clock ratio\n",
> > -			  connector->base.id, connector->name);
> > +		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Failed to configure
> > sink "
> > +			      "scrambling/TMDS bit clock ratio\n",
> > +			       connector->base.id, connector->name);
> >  
> >  	/* Display WA #1143: skl,kbl,cfl */
> >  	if (IS_GEN9_BC(dev_priv)) {
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Patch
diff mbox series

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 284219da7df8..457ca88cd277 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3564,8 +3564,9 @@  static void intel_enable_ddi_hdmi(struct intel_encoder *encoder,
 	if (!intel_hdmi_handle_sink_scrambling(encoder, connector,
 					       crtc_state->hdmi_high_tmds_clock_ratio,
 					       crtc_state->hdmi_scrambling))
-		DRM_ERROR("[CONNECTOR:%d:%s] Failed to configure sink scrambling/TMDS bit clock ratio\n",
-			  connector->base.id, connector->name);
+		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] Failed to configure sink "
+			      "scrambling/TMDS bit clock ratio\n",
+			       connector->base.id, connector->name);
 
 	/* Display WA #1143: skl,kbl,cfl */
 	if (IS_GEN9_BC(dev_priv)) {