| Message ID | 20200303101306.4potflz7na2nn3od@kili.mountain (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 32cf3a610c35cb21e3157f4bbf29d89960e30a36 |
| Headers | show |
| Series | Input: raydium_i2c_ts - fix error codes in raydium_i2c_boot_trigger() | expand |
On Tue, Mar 03, 2020 at 01:13:06PM +0300, Dan Carpenter wrote: > These functions are supposed to return negative error codes but instead > it returns true on failure and false on success. The error codes are > eventually propogated back to user space. > > Fixes: 48a2b783483b ("Input: add Raydium I2C touchscreen driver") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Applied, thank you. > --- > drivers/input/touchscreen/raydium_i2c_ts.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c > index 6ed9f22e6401..fe245439adee 100644 > --- a/drivers/input/touchscreen/raydium_i2c_ts.c > +++ b/drivers/input/touchscreen/raydium_i2c_ts.c > @@ -432,7 +432,7 @@ static int raydium_i2c_write_object(struct i2c_client *client, > return 0; > } > > -static bool raydium_i2c_boot_trigger(struct i2c_client *client) > +static int raydium_i2c_boot_trigger(struct i2c_client *client) > { > static const u8 cmd[7][6] = { > { 0x08, 0x0C, 0x09, 0x00, 0x50, 0xD7 }, > @@ -457,10 +457,10 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client) > } > } > > - return false; > + return 0; > } > > -static bool raydium_i2c_fw_trigger(struct i2c_client *client) > +static int raydium_i2c_fw_trigger(struct i2c_client *client) > { > static const u8 cmd[5][11] = { > { 0, 0x09, 0x71, 0x0C, 0x09, 0x00, 0x50, 0xD7, 0, 0, 0 }, > @@ -483,7 +483,7 @@ static bool raydium_i2c_fw_trigger(struct i2c_client *client) > } > } > > - return false; > + return 0; > } > > static int raydium_i2c_check_path(struct i2c_client *client) > -- > 2.11.0 >
diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index 6ed9f22e6401..fe245439adee 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -432,7 +432,7 @@ static int raydium_i2c_write_object(struct i2c_client *client, return 0; } -static bool raydium_i2c_boot_trigger(struct i2c_client *client) +static int raydium_i2c_boot_trigger(struct i2c_client *client) { static const u8 cmd[7][6] = { { 0x08, 0x0C, 0x09, 0x00, 0x50, 0xD7 }, @@ -457,10 +457,10 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client) } } - return false; + return 0; } -static bool raydium_i2c_fw_trigger(struct i2c_client *client) +static int raydium_i2c_fw_trigger(struct i2c_client *client) { static const u8 cmd[5][11] = { { 0, 0x09, 0x71, 0x0C, 0x09, 0x00, 0x50, 0xD7, 0, 0, 0 }, @@ -483,7 +483,7 @@ static bool raydium_i2c_fw_trigger(struct i2c_client *client) } } - return false; + return 0; } static int raydium_i2c_check_path(struct i2c_client *client)
These functions are supposed to return negative error codes but instead it returns true on failure and false on success. The error codes are eventually propogated back to user space. Fixes: 48a2b783483b ("Input: add Raydium I2C touchscreen driver") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/input/touchscreen/raydium_i2c_ts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)