diff mbox series

venus: vdec: Fix smatch warning in start streaming

Message ID 20200303112122.28703-1-stanimir.varbanov@linaro.org (mailing list archive)
State New, archived
Headers show
Series venus: vdec: Fix smatch warning in start streaming | expand

Commit Message

Stanimir Varbanov March 3, 2020, 11:21 a.m. UTC 
This fixes the following smatch warning in the error path:

drivers/media/platform/qcom/venus/vdec.c:968 vdec_start_streaming()
 warn: inconsistent returns 'mutex:&inst->lock'.
  Locked on:   line 952
  Unlocked on: line 963
               line 968

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
---
 drivers/media/platform/qcom/venus/vdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index f349201c0f0d..4ed2628585a1 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -949,7 +949,7 @@  static int vdec_start_streaming(struct vb2_queue *q, unsigned int count)
 
 	ret = venus_pm_acquire_core(inst);
 	if (ret)
-		return ret;
+		goto error;
 
 	if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
 		ret = vdec_start_capture(inst);