[i-g-t] tests/i915/query: Do not assert engine info rsvd being zero
diff mbox series

Message ID 20200304092901.2347-1-tvrtko.ursulin@linux.intel.com
State New
Headers show
Series
  • [i-g-t] tests/i915/query: Do not assert engine info rsvd being zero
Related show

Commit Message

Tvrtko Ursulin March 4, 2020, 9:29 a.m. UTC
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

These are not input fields and i915 currently leaves them untouched.

In the spirit of trusting the query as the authoritative source of
information, stop asserting these output only reserved fields are zero.

This should prevent the test from auto-failing if we extend the data in
the future.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
---
 tests/i915/i915_query.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Brian Welty March 4, 2020, 5:34 p.m. UTC | #1
On 3/4/2020 1:29 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> 
> These are not input fields and i915 currently leaves them untouched.
> 
> In the spirit of trusting the query as the authoritative source of
> information, stop asserting these output only reserved fields are zero.
> 
> This should prevent the test from auto-failing if we extend the data in
> the future.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Brian Welty <brian.welty@intel.com>

Reviewed-by: Brian Welty <brian.welty@intel.com>

> ---
>  tests/i915/i915_query.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
> index 71807425fbc4..e7c6fc91e32b 100644
> --- a/tests/i915/i915_query.c
> +++ b/tests/i915/i915_query.c
> @@ -690,11 +690,6 @@ static void engines(int fd)
>  			  engine->flags,
>  			  engine->capabilities);
>  
> -		/* MBZ fields. */
> -		igt_assert_eq(engine->rsvd0, 0);
> -		igt_assert_eq(engine->rsvd1[0], 0);
> -		igt_assert_eq(engine->rsvd1[1], 0);
> -
>  		switch (engine->engine.engine_class) {
>  		case I915_ENGINE_CLASS_RENDER:
>  			/* Will be tested later. */
>

Patch
diff mbox series

diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c
index 71807425fbc4..e7c6fc91e32b 100644
--- a/tests/i915/i915_query.c
+++ b/tests/i915/i915_query.c
@@ -690,11 +690,6 @@  static void engines(int fd)
 			  engine->flags,
 			  engine->capabilities);
 
-		/* MBZ fields. */
-		igt_assert_eq(engine->rsvd0, 0);
-		igt_assert_eq(engine->rsvd1[0], 0);
-		igt_assert_eq(engine->rsvd1[1], 0);
-
 		switch (engine->engine.engine_class) {
 		case I915_ENGINE_CLASS_RENDER:
 			/* Will be tested later. */