| Message ID | 1583328320-9981-1-git-send-email-vbadigan@codeaurora.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d3392339cae94b2ab01646a22f67ce464e46ed68 |
| Headers | show |
| Series | [V2] mmc: cqhci: Update cqhci memory ioresource name | expand |
On 4/03/20 3:25 pm, Veerabhadrarao Badiganti wrote: > Update cqhci memory ioresource name from cqhci_mem to cqhci since > suffix _mem is redundant. > > Only sdhci-msm driver is making use of this resource as of now. > No other vendor's driver is using it. So this update shouldn't affect > any other vendor's cqhci functionality. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > Corresponding binding change: > https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/ > > Changes sicne V1: > - Updated commit text expalining this change affects *only* > qcom cqhci functionality. > > --- > drivers/mmc/host/cqhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c > index e2ea2c4..e24b8ff 100644 > --- a/drivers/mmc/host/cqhci.c > +++ b/drivers/mmc/host/cqhci.c > @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev) > > /* check and setup CMDQ interface */ > cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "cqhci_mem"); > + "cqhci"); > if (!cqhci_memres) { > dev_dbg(&pdev->dev, "CMDQ not supported\n"); > return ERR_PTR(-EINVAL); >
Hi, On Wed, Mar 4, 2020 at 5:25 AM Veerabhadrarao Badiganti <vbadigan@codeaurora.org> wrote: > > Update cqhci memory ioresource name from cqhci_mem to cqhci since > suffix _mem is redundant. > > Only sdhci-msm driver is making use of this resource as of now. > No other vendor's driver is using it. So this update shouldn't affect > any other vendor's cqhci functionality. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> > --- > Corresponding binding change: > https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/ > > Changes sicne V1: > - Updated commit text expalining this change affects *only* > qcom cqhci functionality. > > --- > drivers/mmc/host/cqhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ...now I guess the last thing is the dts change... Reviewed-by: Douglas Anderson <dianders@chromium.org>
On Wed 04 Mar 05:25 PST 2020, Veerabhadrarao Badiganti wrote: > Update cqhci memory ioresource name from cqhci_mem to cqhci since > suffix _mem is redundant. > > Only sdhci-msm driver is making use of this resource as of now. > No other vendor's driver is using it. So this update shouldn't affect > any other vendor's cqhci functionality. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> I do favor using names without the "_mem" suffix and it seems like the existing code only acquire the first two regions by index. So this should be fine. Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> But I do expect to see some patches fixing up the 8 dts files that now has invalid reg-names. Regards, Bjorn > --- > Corresponding binding change: > https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/ > > Changes sicne V1: > - Updated commit text expalining this change affects *only* > qcom cqhci functionality. > > --- > drivers/mmc/host/cqhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c > index e2ea2c4..e24b8ff 100644 > --- a/drivers/mmc/host/cqhci.c > +++ b/drivers/mmc/host/cqhci.c > @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev) > > /* check and setup CMDQ interface */ > cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "cqhci_mem"); > + "cqhci"); > if (!cqhci_memres) { > dev_dbg(&pdev->dev, "CMDQ not supported\n"); > return ERR_PTR(-EINVAL); > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
On Wed, 4 Mar 2020 at 14:25, Veerabhadrarao Badiganti <vbadigan@codeaurora.org> wrote: > > Update cqhci memory ioresource name from cqhci_mem to cqhci since > suffix _mem is redundant. > > Only sdhci-msm driver is making use of this resource as of now. > No other vendor's driver is using it. So this update shouldn't affect > any other vendor's cqhci functionality. > > Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> Applied for next, thanks! Kind regards Uffe > --- > Corresponding binding change: > https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/ > > Changes sicne V1: > - Updated commit text expalining this change affects *only* > qcom cqhci functionality. > > --- > drivers/mmc/host/cqhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c > index e2ea2c4..e24b8ff 100644 > --- a/drivers/mmc/host/cqhci.c > +++ b/drivers/mmc/host/cqhci.c > @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev) > > /* check and setup CMDQ interface */ > cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM, > - "cqhci_mem"); > + "cqhci"); > if (!cqhci_memres) { > dev_dbg(&pdev->dev, "CMDQ not supported\n"); > return ERR_PTR(-EINVAL); > -- > Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c index e2ea2c4..e24b8ff 100644 --- a/drivers/mmc/host/cqhci.c +++ b/drivers/mmc/host/cqhci.c @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev) /* check and setup CMDQ interface */ cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM, - "cqhci_mem"); + "cqhci"); if (!cqhci_memres) { dev_dbg(&pdev->dev, "CMDQ not supported\n"); return ERR_PTR(-EINVAL);
Update cqhci memory ioresource name from cqhci_mem to cqhci since suffix _mem is redundant. Only sdhci-msm driver is making use of this resource as of now. No other vendor's driver is using it. So this update shouldn't affect any other vendor's cqhci functionality. Signed-off-by: Veerabhadrarao Badiganti <vbadigan@codeaurora.org> --- Corresponding binding change: https://lore.kernel.org/linux-arm-msm/1582545470-11530-1-git-send-email-vbadigan@codeaurora.org/ Changes sicne V1: - Updated commit text expalining this change affects *only* qcom cqhci functionality. --- drivers/mmc/host/cqhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)