[PULL,25/29] monitor: Add allow_hmp parameter to monitor_init()

Commit Message

Kevin Wolf March 6, 2020, 5:14 p.m. UTC

Add a new parameter allow_hmp to monitor_init() so that the storage
daemon can disable HMP.

Signed-off-by: Kevin Wolf <[e-mail]>
Message-Id: <[e-mail]>
Acked-by: Stefan Hajnoczi <[e-mail]>
Signed-off-by: Kevin Wolf <[e-mail]>
---
 qapi/control.json         |  3 ++-
 include/monitor/monitor.h |  2 +-
 monitor/monitor.c         | 12 ++++++++++--
 3 files changed, 13 insertions(+), 4 deletions(-)

Patch

diff --git a/qapi/control.json b/qapi/control.json
index 3ee086aec7..85b12fe0fb 100644
--- a/qapi/control.json
+++ b/qapi/control.json
@@ -237,7 +237,8 @@ 
 #
 # @id:          Name of the monitor
 #
-# @mode:        Selects the monitor mode (default: readline)
+# @mode:        Selects the monitor mode (default: readline in the system
+#               emulator, control in qemu-storage-daemon)
 #
 # @pretty:      Enables pretty printing (QMP only)
 #
diff --git a/include/monitor/monitor.h b/include/monitor/monitor.h
index ad823b9edb..1018d754a6 100644
--- a/include/monitor/monitor.h
+++ b/include/monitor/monitor.h
@@ -19,7 +19,7 @@  void monitor_init_globals(void);
 void monitor_init_globals_core(void);
 void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp);
 void monitor_init_hmp(Chardev *chr, bool use_readline, Error **errp);
-int monitor_init(MonitorOptions *opts, Error **errp);
+int monitor_init(MonitorOptions *opts, bool allow_hmp, Error **errp);
 int monitor_init_opts(QemuOpts *opts, Error **errp);
 void monitor_cleanup(void);
 
diff --git a/monitor/monitor.c b/monitor/monitor.c
index 2282bf6780..125494410a 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -611,7 +611,7 @@  void monitor_init_globals_core(void)
                                    NULL);
 }
 
-int monitor_init(MonitorOptions *opts, Error **errp)
+int monitor_init(MonitorOptions *opts, bool allow_hmp, Error **errp)
 {
     Chardev *chr;
     Error *local_err = NULL;
@@ -622,11 +622,19 @@  int monitor_init(MonitorOptions *opts, Error **errp)
         return -1;
     }
 
+    if (!opts->has_mode) {
+        opts->mode = allow_hmp ? MONITOR_MODE_READLINE : MONITOR_MODE_CONTROL;
+    }
+
     switch (opts->mode) {
     case MONITOR_MODE_CONTROL:
         monitor_init_qmp(chr, opts->pretty, &local_err);
         break;
     case MONITOR_MODE_READLINE:
+        if (!allow_hmp) {
+            error_setg(errp, "Only QMP is supported");
+            return -1;
+        }
         if (opts->pretty) {
             warn_report("'pretty' is deprecated for HMP monitors, it has no "
                         "effect and will be removed in future versions");
@@ -658,7 +666,7 @@  int monitor_init_opts(QemuOpts *opts, Error **errp)
         goto out;
     }
 
-    monitor_init(options, &local_err);
+    monitor_init(options, true, &local_err);
     qapi_free_MonitorOptions(options);
 
 out: