checkpolicy: Treat invalid characters as an error
diff mbox series

Message ID 20200310144133.381567-1-dburgener@linux.microsoft.com
State Accepted
Headers show
Series
  • checkpolicy: Treat invalid characters as an error
Related show

Commit Message

Daniel Burgener March 10, 2020, 2:41 p.m. UTC
Previously the behavior was to warn, discard the character and proceed. Now the build will halt upon encountering an expected character.

Signed-off-by: Daniel Burgener <dburgener@linux.microsoft.com>
---
 checkpolicy/policy_scan.l | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

James Carter March 10, 2020, 7:19 p.m. UTC | #1
On Tue, Mar 10, 2020 at 10:42 AM Daniel Burgener
<dburgener@linux.microsoft.com> wrote:
>
> Previously the behavior was to warn, discard the character and proceed. Now the build will halt upon encountering an expected character.
>
> Signed-off-by: Daniel Burgener <dburgener@linux.microsoft.com>

Acked-by: James Carter <jwcart2@gmail.com>


> ---
>  checkpolicy/policy_scan.l | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
> index e2f676e4..8c100f3d 100644
> --- a/checkpolicy/policy_scan.l
> +++ b/checkpolicy/policy_scan.l
> @@ -290,7 +290,7 @@ GLBLUB                              { return(GLBLUB); }
>  "]" |
>  "~" |
>  "*"                            { return(yytext[0]); }
> -.                               { yywarn("unrecognized character");}
> +.                               { yyerror("unrecognized character");}
>  %%
>  int yyerror(const char *msg)
>  {
> --
> 2.24.1
>
James Carter March 11, 2020, 6:18 p.m. UTC | #2
On Tue, Mar 10, 2020 at 3:19 PM James Carter <jwcart2@gmail.com> wrote:
>
> On Tue, Mar 10, 2020 at 10:42 AM Daniel Burgener
> <dburgener@linux.microsoft.com> wrote:
> >
> > Previously the behavior was to warn, discard the character and proceed. Now the build will halt upon encountering an expected character.
> >
> > Signed-off-by: Daniel Burgener <dburgener@linux.microsoft.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
>
>

Thanks, applied.
Jim

> > ---
> >  checkpolicy/policy_scan.l | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
> > index e2f676e4..8c100f3d 100644
> > --- a/checkpolicy/policy_scan.l
> > +++ b/checkpolicy/policy_scan.l
> > @@ -290,7 +290,7 @@ GLBLUB                              { return(GLBLUB); }
> >  "]" |
> >  "~" |
> >  "*"                            { return(yytext[0]); }
> > -.                               { yywarn("unrecognized character");}
> > +.                               { yyerror("unrecognized character");}
> >  %%
> >  int yyerror(const char *msg)
> >  {
> > --
> > 2.24.1
> >

Patch
diff mbox series

diff --git a/checkpolicy/policy_scan.l b/checkpolicy/policy_scan.l
index e2f676e4..8c100f3d 100644
--- a/checkpolicy/policy_scan.l
+++ b/checkpolicy/policy_scan.l
@@ -290,7 +290,7 @@  GLBLUB				{ return(GLBLUB); }
 "]" |
 "~" |
 "*"				{ return(yytext[0]); } 
-.                               { yywarn("unrecognized character");}
+.                               { yyerror("unrecognized character");}
 %%
 int yyerror(const char *msg)
 {