| Message ID | 20200311061328.17614-1-kai.heng.feng@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3b36b13d5e69d6f51ff1c55d1b404a74646c9757 |
| Headers | show |
| Series | ALSA: hda/realtek: Fix pop noise on ALC225 | expand |
On Wed, 11 Mar 2020 07:13:28 +0100, Kai-Heng Feng wrote: > > Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to > 0") makes the ALC225 have pop noise on S3 resume and cold boot. > > So partially revert this commit for ALC225 to fix the regression. > > Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") > BugLink: https://bugs.launchpad.net/bugs/1866357 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- Hrm, it's rather surprising. The power_save_node was thought to be a cause of the pop noise, but in this case it fixes. It's interesting because this codec chip has no loopback mixer, and the connection is directly from DAC to pin, so in theory, it shouldn't be influenced from other nodes. Anyways, a slight concern is that this might cause a regression on another machine. But who knows, maybe the influence is very limited. Let's apply it and see what happens. thanks, Takashi
> On Mar 11, 2020, at 14:54, Takashi Iwai <tiwai@suse.de> wrote: > > On Wed, 11 Mar 2020 07:13:28 +0100, > Kai-Heng Feng wrote: >> >> Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to >> 0") makes the ALC225 have pop noise on S3 resume and cold boot. >> >> So partially revert this commit for ALC225 to fix the regression. >> >> Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") >> BugLink: https://bugs.launchpad.net/bugs/1866357 >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> >> --- > > Hrm, it's rather surprising. The power_save_node was thought to be a > cause of the pop noise, but in this case it fixes. It's interesting > because this codec chip has no loopback mixer, and the connection is > directly from DAC to pin, so in theory, it shouldn't be influenced > from other nodes. > > Anyways, a slight concern is that this might cause a regression on > another machine. But who knows, maybe the influence is very limited. > Let's apply it and see what happens. If that happens I'll write a specific fixup for the affected model. Kai-Heng > > > thanks, > > Takashi
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 0ac06ff1a17c..7b83b020ac3c 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8051,6 +8051,8 @@ static int patch_alc269(struct hda_codec *codec) spec->gen.mixer_nid = 0; break; case 0x10ec0225: + codec->power_save_node = 1; + /* fall through */ case 0x10ec0295: case 0x10ec0299: spec->codec_variant = ALC269_TYPE_ALC225;
Commit 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") makes the ALC225 have pop noise on S3 resume and cold boot. So partially revert this commit for ALC225 to fix the regression. Fixes: 317d9313925c ("ALSA: hda/realtek - Set default power save node to 0") BugLink: https://bugs.launchpad.net/bugs/1866357 Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> --- sound/pci/hda/patch_realtek.c | 2 ++ 1 file changed, 2 insertions(+)