| Message ID | 20200313210954.148686-3-josef@toxicpanda.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Drop some mis-uses of READA | expand |
On 2020/3/14 上午5:09, Josef Bacik wrote: > Here we are just searching down to the bytenr we're building the backref > tree for, and all of it's paths to the roots. These bytenrs are not > guaranteed to be anywhere near each other, so the READA just generates > extra latency. > > Signed-off-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > --- > fs/btrfs/relocation.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c > index 4fb7e3cc2aca..3ccc126d0df3 100644 > --- a/fs/btrfs/relocation.c > +++ b/fs/btrfs/relocation.c > @@ -759,8 +759,6 @@ struct backref_node *build_backref_tree(struct reloc_control *rc, > err = -ENOMEM; > goto out; > } > - path1->reada = READA_FORWARD; > - path2->reada = READA_FORWARD; > > node = alloc_backref_node(cache); > if (!node) { >
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 4fb7e3cc2aca..3ccc126d0df3 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -759,8 +759,6 @@ struct backref_node *build_backref_tree(struct reloc_control *rc, err = -ENOMEM; goto out; } - path1->reada = READA_FORWARD; - path2->reada = READA_FORWARD; node = alloc_backref_node(cache); if (!node) {
Here we are just searching down to the bytenr we're building the backref tree for, and all of it's paths to the roots. These bytenrs are not guaranteed to be anywhere near each other, so the READA just generates extra latency. Signed-off-by: Josef Bacik <josef@toxicpanda.com> --- fs/btrfs/relocation.c | 2 -- 1 file changed, 2 deletions(-)