| Message ID | 20200314113524.23031-1-krzk@kernel.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b33d232e6112aa175f08e8105de0a4da14f5dcbb |
| Headers | show |
| Series | pwm: meson: Fix confusing indentation | expand |
On Sat, Mar 14, 2020 at 12:35:24PM +0100, Krzysztof Kozlowski wrote: > Fix indentation of return block. Smatch warning: > drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> This exists since commit 211ed630753d ("pwm: Add support for Meson PWM Controller") in 2016. Added Neil to Cc:. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
Le 14/03/2020 à 22:43, Uwe Kleine-König a écrit : > On Sat, Mar 14, 2020 at 12:35:24PM +0100, Krzysztof Kozlowski wrote: >> Fix indentation of return block. Smatch warning: >> drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting >> >> Reported-by: kbuild test robot <lkp@intel.com> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > This exists since commit 211ed630753d ("pwm: Add support for Meson PWM > Controller") in 2016. Added Neil to Cc:. > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Thanks > Uwe > Missing Fixes: 211ed630753d ("pwm: Add support for Meson PWM Controller") With that Acked-by: Neil Armstrong <narmstrong@baylibre.com> Neil
Hello: This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next). On Sat, 14 Mar 2020 12:35:24 +0100 you wrote: > Fix indentation of return block. Smatch warning: > drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting > > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > drivers/pwm/pwm-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is a summary with links: - pwm: meson: Fix confusing indentation https://git.kernel.org/khilman/linux-amlogic/c/b33d232e6112aa175f08e8105de0a4da14f5dcbb You are awesome, thank you!
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 6245bbdb6e6c..8cf9129caa39 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -136,7 +136,7 @@ static int meson_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm) dev_err(dev, "failed to set parent %s for %s: %d\n", __clk_get_name(channel->clk_parent), __clk_get_name(channel->clk), err); - return err; + return err; } }
Fix indentation of return block. Smatch warning: drivers/pwm/pwm-meson.c:139 meson_pwm_request() warn: inconsistent indenting Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- drivers/pwm/pwm-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)