[v1,16/36] dt-bindings: display: convert lg,lg4573 to DT Schema
diff mbox series

Message ID 20200315134416.16527-17-sam@ravnborg.org
State New
Headers show
Series
  • dt-bindings: display: convert remaning panel bindings to DT Schema
Related show

Commit Message

Sam Ravnborg March 15, 2020, 1:43 p.m. UTC
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Heiko Schocher <hs@denx.de>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
---
 .../bindings/display/panel/lg,lg4573.txt      | 19 ---------
 .../bindings/display/panel/lg,lg4573.yaml     | 41 +++++++++++++++++++
 2 files changed, 41 insertions(+), 19 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml

Comments

Heiko Schocher March 16, 2020, 4:56 a.m. UTC | #1
Hello Sam,

Am 15.03.2020 um 14:43 schrieb Sam Ravnborg:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>   .../bindings/display/panel/lg,lg4573.txt      | 19 ---------
>   .../bindings/display/panel/lg,lg4573.yaml     | 41 +++++++++++++++++++
>   2 files changed, 41 insertions(+), 19 deletions(-)
>   delete mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
>   create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml

Reviewed-by: Heiko Schocher <hs@denx.de>

Thanks!

bye,
Heiko
Rob Herring March 19, 2020, 2:56 a.m. UTC | #2
On Sun, Mar 15, 2020 at 02:43:56PM +0100, Sam Ravnborg wrote:
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> ---
>  .../bindings/display/panel/lg,lg4573.txt      | 19 ---------
>  .../bindings/display/panel/lg,lg4573.yaml     | 41 +++++++++++++++++++
>  2 files changed, 41 insertions(+), 19 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt b/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
> deleted file mode 100644
> index 824441f4e95a..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -LG LG4573 TFT Liquid Crystal Display with SPI control bus
> -
> -Required properties:
> -  - compatible: "lg,lg4573"
> -  - reg: address of the panel on the SPI bus
> -
> -The panel must obey rules for SPI slave device specified in document [1].
> -
> -[1]: Documentation/devicetree/bindings/spi/spi-bus.txt
> -
> -Example:
> -
> -	lcd_panel: display@0 {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
> -		compatible = "lg,lg4573";
> -		spi-max-frequency = <10000000>;
> -		reg = <0>;
> -	};
> diff --git a/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml b/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml
> new file mode 100644
> index 000000000000..b5b475cf8406
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lg,lg4573.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LG LG4573 TFT Liquid Crystal Display with SPI control bus
> +
> +maintainers:
> +  - Heiko Schocher <hs@denx.de>
> +
> +allOf:
> +  - $ref: ../../spi/spi-slave.yaml#
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: lg,lg4573
> +
> +  reg: true
> +  spi-max-frequency: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    spi {
> +        compatible = "fsl,imx6q-ecspi", "fsl,imx51-ecspi";

Better to drop this or it's going to fail when there's a schema for this 
spi controller.

> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        lcd_panel: display@0 {
> +            compatible = "lg,lg4573";
> +            spi-max-frequency = <10000000>;
> +            reg = <0>;
> +        };
> +    };
> +
> +...
> -- 
> 2.20.1
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt b/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
deleted file mode 100644
index 824441f4e95a..000000000000
--- a/Documentation/devicetree/bindings/display/panel/lg,lg4573.txt
+++ /dev/null
@@ -1,19 +0,0 @@ 
-LG LG4573 TFT Liquid Crystal Display with SPI control bus
-
-Required properties:
-  - compatible: "lg,lg4573"
-  - reg: address of the panel on the SPI bus
-
-The panel must obey rules for SPI slave device specified in document [1].
-
-[1]: Documentation/devicetree/bindings/spi/spi-bus.txt
-
-Example:
-
-	lcd_panel: display@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
-		compatible = "lg,lg4573";
-		spi-max-frequency = <10000000>;
-		reg = <0>;
-	};
diff --git a/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml b/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml
new file mode 100644
index 000000000000..b5b475cf8406
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lg4573.yaml
@@ -0,0 +1,41 @@ 
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/lg,lg4573.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LG LG4573 TFT Liquid Crystal Display with SPI control bus
+
+maintainers:
+  - Heiko Schocher <hs@denx.de>
+
+allOf:
+  - $ref: ../../spi/spi-slave.yaml#
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: lg,lg4573
+
+  reg: true
+  spi-max-frequency: true
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    spi {
+        compatible = "fsl,imx6q-ecspi", "fsl,imx51-ecspi";
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        lcd_panel: display@0 {
+            compatible = "lg,lg4573";
+            spi-max-frequency = <10000000>;
+            reg = <0>;
+        };
+    };
+
+...