[05/28] ARM: dts: pxa3xx: Fix up encoding of the /gpio interrupts property
diff mbox series

Message ID 20200317093922.20785-6-lkundrak@v3.sk
State New
Headers show
Series
  • DT: Improve validation for Marvell SoCs
Related show

Commit Message

Lubomir Rintel March 17, 2020, 9:38 a.m. UTC
This way the device tree validator learns that each cell of the property
constitutes a separate item. Otherwise it gets unnecessairly upset:

  pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
      [[8, 9, 10]] is too short

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 arch/arm/boot/dts/pxa3xx.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Lunn March 17, 2020, 1:28 p.m. UTC | #1
On Tue, Mar 17, 2020 at 10:38:59AM +0100, Lubomir Rintel wrote:
> This way the device tree validator learns that each cell of the property
> constitutes a separate item. Otherwise it gets unnecessairly upset:
> 
>   pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
>       [[8, 9, 10]] is too short
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Robert Jarzmik March 21, 2020, 7:36 a.m. UTC | #2
Andrew Lunn <andrew@lunn.ch> writes:

> On Tue, Mar 17, 2020 at 10:38:59AM +0100, Lubomir Rintel wrote:
>> This way the device tree validator learns that each cell of the property
>> constitutes a separate item. Otherwise it gets unnecessairly upset:
>> 
>>   pxa300-raumfeld-speaker-s.dt.yaml: gpio@40e00000: interrupts:
>>       [[8, 9, 10]] is too short
>> 
>> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr.>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/pxa3xx.dtsi b/arch/arm/boot/dts/pxa3xx.dtsi
index c237a0e4b12ae..d19674812cd2d 100644
--- a/arch/arm/boot/dts/pxa3xx.dtsi
+++ b/arch/arm/boot/dts/pxa3xx.dtsi
@@ -170,7 +170,7 @@  gpio: gpio@40e00000 {
 			clocks = <&clks CLK_GPIO>;
 			gpio-ranges = <&pinctrl 0 0 128>;
 			interrupt-names = "gpio0", "gpio1", "gpio_mux";
-			interrupts = <8 9 10>;
+			interrupts = <8>, <9>, <10>;
 			gpio-controller;
 			#gpio-cells = <0x2>;
 			interrupt-controller;