diff mbox series

[5/4] scripts/simplebench: fix python script ! headers

Message ID 20200318170226.12186-1-vsementsov@virtuozzo.com (mailing list archive)
State New, archived
Headers show
Series [PULL,1/4] scripts/simplebench: add simplebench.py | expand

Commit Message

Vladimir Sementsov-Ogievskiy March 18, 2020, 5:02 p.m. UTC
- simplebench.py is not for executing by itself, so drop the header
- in bench_block_job.py fix python to python3

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 scripts/simplebench/bench_block_job.py | 2 +-
 scripts/simplebench/simplebench.py     | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

Comments

Philippe Mathieu-Daudé March 18, 2020, 10:31 p.m. UTC | #1
On 3/18/20 6:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> - simplebench.py is not for executing by itself, so drop the header
> - in bench_block_job.py fix python to python3
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   scripts/simplebench/bench_block_job.py | 2 +-
>   scripts/simplebench/simplebench.py     | 2 --
>   2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
> index 9808d696cf..a0dda1dc4e 100755
> --- a/scripts/simplebench/bench_block_job.py
> +++ b/scripts/simplebench/bench_block_job.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
>   #
>   # Benchmark block jobs
>   #
> diff --git a/scripts/simplebench/simplebench.py b/scripts/simplebench/simplebench.py
> index 59e7314ff6..7e25f3590b 100644
> --- a/scripts/simplebench/simplebench.py
> +++ b/scripts/simplebench/simplebench.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>   # Simple benchmarking framework
>   #
>   # Copyright (c) 2019 Virtuozzo International GmbH.
> 

I'd rather see this squashed in patches 1 and 2, if not:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
index 9808d696cf..a0dda1dc4e 100755
--- a/scripts/simplebench/bench_block_job.py
+++ b/scripts/simplebench/bench_block_job.py
@@ -1,4 +1,4 @@ 
-#!/usr/bin/env python
+#!/usr/bin/env python3
 #
 # Benchmark block jobs
 #
diff --git a/scripts/simplebench/simplebench.py b/scripts/simplebench/simplebench.py
index 59e7314ff6..7e25f3590b 100644
--- a/scripts/simplebench/simplebench.py
+++ b/scripts/simplebench/simplebench.py
@@ -1,5 +1,3 @@ 
-#!/usr/bin/env python
-#
 # Simple benchmarking framework
 #
 # Copyright (c) 2019 Virtuozzo International GmbH.