diff mbox series

[v2,3/3] ASoC: rt5682: Add the descriptions for the DMIC clock rate and delay settings

Message ID 20200319074328.25284-3-oder_chiou@realtek.com (mailing list archive)
State New, archived
Headers show
Series [v2,1/3] ASoC: rt5682: Add a property for DMIC clock rate setting | expand

Commit Message

Oder Chiou March 19, 2020, 7:43 a.m. UTC
The patch adds the descriptions for the DMIC clock rate and delay settings.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Mark Brown March 19, 2020, 12:35 p.m. UTC | #1
On Thu, Mar 19, 2020 at 03:43:28PM +0800, Oder Chiou wrote:

> +- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
> +  particular DMIC.

Lars mentioned on the previous version that this should have units on it
so -hz (I assume, perhaps the unit is different) here.  As he said it'd
also be a bit more idiomatic to say clock rather than clk.

> +- realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of
> +  the particular DMIC.

This change is good though.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index ac98151d29e4..f1d924179d67 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -38,6 +38,12 @@  Optional properties:
 - clocks : phandle and clock specifier for codec MCLK.
 - clock-names : Clock name string for 'clocks' attribute, should be "mclk".
 
+- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
+  particular DMIC.
+
+- realtek,dmic-delay-ms : Set the delay time (ms) for the requirement of
+  the particular DMIC.
+
 Pins on the device (for linking into audio routes) for RT5682:
 
   * DMIC L1