arm64: dts: imx8mq-librem5-devkit: Use 0.9V for VDD_GPU
diff mbox series

Message ID d9bfb11e3d66376792089d54d7d52fe3778efa33.1584636213.git.agx@sigxcpu.org
State New
Headers show
Series
  • arm64: dts: imx8mq-librem5-devkit: Use 0.9V for VDD_GPU
Related show

Commit Message

Guido Günther March 19, 2020, 4:46 p.m. UTC
According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
when not overclocking to 1GHz (which we currently don't do).

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Kepplinger March 23, 2020, 7:17 p.m. UTC | #1
On 19.03.20 17:46, Guido Günther wrote:
> According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
> when not overclocking to 1GHz (which we currently don't do).
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index c47a26cf8e43..736b250bc9c2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -318,7 +318,7 @@
>  				regulator-min-microvolt = <700000>;
>  				regulator-max-microvolt = <1300000>;
>  				regulator-always-on;
> -				rohm,dvs-run-voltage = <1000000>;
> +				rohm,dvs-run-voltage = <900000>;
>  			};
>  
>  			buck4_reg: BUCK4 {
> 


since I'm running this now:

Tested-by: Martin Kepplinger <martin.kepplinger@puri.sm>

thanks
Shawn Guo April 20, 2020, 2:54 p.m. UTC | #2
On Thu, Mar 19, 2020 at 05:46:02PM +0100, Guido Günther wrote:
> According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
> when not overclocking to 1GHz (which we currently don't do).
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

It doesn't apply to my branch.

Shawn

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> index c47a26cf8e43..736b250bc9c2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> @@ -318,7 +318,7 @@
>  				regulator-min-microvolt = <700000>;
>  				regulator-max-microvolt = <1300000>;
>  				regulator-always-on;
> -				rohm,dvs-run-voltage = <1000000>;
> +				rohm,dvs-run-voltage = <900000>;
>  			};
>  
>  			buck4_reg: BUCK4 {
> -- 
> 2.23.0
>
Guido Günther April 20, 2020, 4:32 p.m. UTC | #3
Hi,
On Mon, Apr 20, 2020 at 10:54:59PM +0800, Shawn Guo wrote:
> On Thu, Mar 19, 2020 at 05:46:02PM +0100, Guido Günther wrote:
> > According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
> > when not overclocking to 1GHz (which we currently don't do).
> > 
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> 
> It doesn't apply to my branch.

This was against linux next when i sent it, can you link to the branch
it should apply to please?
 -- Guido

> 
> Shawn
> 
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index c47a26cf8e43..736b250bc9c2 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -318,7 +318,7 @@
> >  				regulator-min-microvolt = <700000>;
> >  				regulator-max-microvolt = <1300000>;
> >  				regulator-always-on;
> > -				rohm,dvs-run-voltage = <1000000>;
> > +				rohm,dvs-run-voltage = <900000>;
> >  			};
> >  
> >  			buck4_reg: BUCK4 {
> > -- 
> > 2.23.0
> > 
>
Shawn Guo April 21, 2020, 3:03 a.m. UTC | #4
On Mon, Apr 20, 2020 at 06:32:24PM +0200, Guido Günther wrote:
> Hi,
> On Mon, Apr 20, 2020 at 10:54:59PM +0800, Shawn Guo wrote:
> > On Thu, Mar 19, 2020 at 05:46:02PM +0100, Guido Günther wrote:
> > > According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
> > > when not overclocking to 1GHz (which we currently don't do).
> > > 
> > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > 
> > It doesn't apply to my branch.
> 
> This was against linux next when i sent it, can you link to the branch
> it should apply to please?

Here it is:

 git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next

Or even better:

 git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/dt64

Shawn
Guido Günther April 21, 2020, 2:45 p.m. UTC | #5
Hi,
On Tue, Apr 21, 2020 at 11:03:07AM +0800, Shawn Guo wrote:
> On Mon, Apr 20, 2020 at 06:32:24PM +0200, Guido Günther wrote:
> > Hi,
> > On Mon, Apr 20, 2020 at 10:54:59PM +0800, Shawn Guo wrote:
> > > On Thu, Mar 19, 2020 at 05:46:02PM +0100, Guido Günther wrote:
> > > > According to the imx8mq data sheet running VDD_GPU at 0.9V is enough
> > > > when not overclocking to 1GHz (which we currently don't do).
> > > > 
> > > > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> > > 
> > > It doesn't apply to my branch.
> > 
> > This was against linux next when i sent it, can you link to the branch
> > it should apply to please?
> 
> Here it is:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
> 
> Or even better:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git imx/dt64

Thanks - and sorry for getting confused with all the kernel trees
around. v2 should apply to the above:

   https://lore.kernel.org/linux-arm-kernel/55399d6b297e329f125a71aea16e5f48c2857945.1587480093.git.agx@sigxcpu.org/T/#mfa29f121347a9d3d76bb14d58fc63fe39767db9c

Cheers,
 -- Guido

> 
> Shawn
>

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
index c47a26cf8e43..736b250bc9c2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
@@ -318,7 +318,7 @@ 
 				regulator-min-microvolt = <700000>;
 				regulator-max-microvolt = <1300000>;
 				regulator-always-on;
-				rohm,dvs-run-voltage = <1000000>;
+				rohm,dvs-run-voltage = <900000>;
 			};
 
 			buck4_reg: BUCK4 {