[1/4] x86/ucode/amd: Fix assertion in compare_patch()
diff mbox series

Message ID 20200320212453.21685-2-andrew.cooper3@citrix.com
State New
Headers show
Series
  • x86/ucode: Cleanup - Part 2/n
Related show

Commit Message

Andrew Cooper March 20, 2020, 9:24 p.m. UTC
This is clearly a typo.

Fixes: 9da23943ccd "microcode: introduce a global cache of ucode patch"
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: Jan Beulich <JBeulich@suse.com>
CC: Wei Liu <wl@xen.org>
CC: Roger Pau Monné <roger.pau@citrix.com>
---
 xen/arch/x86/cpu/microcode/amd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu March 21, 2020, 4:45 p.m. UTC | #1
On Fri, Mar 20, 2020 at 09:24:49PM +0000, Andrew Cooper wrote:
> This is clearly a typo.
> 
> Fixes: 9da23943ccd "microcode: introduce a global cache of ucode patch"
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Wei Liu <wl@xen.org>

Patch
diff mbox series

diff --git a/xen/arch/x86/cpu/microcode/amd.c b/xen/arch/x86/cpu/microcode/amd.c
index 99e2449eee..d4b2874de6 100644
--- a/xen/arch/x86/cpu/microcode/amd.c
+++ b/xen/arch/x86/cpu/microcode/amd.c
@@ -222,7 +222,7 @@  static enum microcode_match_result compare_patch(
 
     /* Both patches to compare are supposed to be applicable to local CPU. */
     ASSERT(microcode_fits(new->mc_amd) != MIS_UCODE);
-    ASSERT(microcode_fits(new->mc_amd) != MIS_UCODE);
+    ASSERT(microcode_fits(old->mc_amd) != MIS_UCODE);
 
     return compare_header(new_header, old_header);
 }