[15/17] xen/x86: p2m: Rework printk format in audit_p2m()
diff mbox series

Message ID 20200322161418.31606-16-julien@xen.org
State New
Headers show
Series
  • Bunch of typesafe conversion
Related show

Commit Message

Julien Grall March 22, 2020, 4:14 p.m. UTC
From: Julien Grall <julien.grall@arm.com>

One of the printk format in audit_p2m() may be difficult to read as it
is not clear what is the first number.

Furthermore, the format can now take advantage of %pd.

Signed-off-by: Julien Grall <julien.grall@arm.com>

---
    This was originally sent as part of "xen/arm: Properly disable M2P
    on Arm" [1].

    [1] <20190603160350.29806-1-julien.grall@arm.com>
---
 xen/arch/x86/mm/p2m.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jan Beulich March 27, 2020, 12:45 p.m. UTC | #1
On 22.03.2020 17:14, julien@xen.org wrote:
> From: Julien Grall <julien.grall@arm.com>
> 
> One of the printk format in audit_p2m() may be difficult to read as it
> is not clear what is the first number.
> 
> Furthermore, the format can now take advantage of %pd.
> 
> Signed-off-by: Julien Grall <julien.grall@arm.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Patch
diff mbox series

diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
index 45b4b784d3..b6b01a71c8 100644
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -2851,8 +2851,7 @@  void audit_p2m(struct domain *d,
 
         if ( od != d )
         {
-            P2M_PRINTK("wrong owner %#lx -> %p(%u) != %p(%u)\n",
-                       mfn, od, (od?od->domain_id:-1), d, d->domain_id);
+            P2M_PRINTK("mfn %"PRI_mfn" owner %pd != %pd\n", mfn, od, d);
             continue;
         }