| Message ID | 469bf8db1c228913e72841367182fba2168fe795.1584904896.git.mh12gx2825@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: adc: General code reformatting / cleanup patchset | expand |
On Mon, 2020-03-23 at 01:27 +0530, Deepak R Varma wrote: > [External] > > Checkpatch would flash a check message around a stringified macro > argument containing a '-' character. Add comment to indicate the > argument is legitimate and doesn't need fixing. Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > Suggested-by: Lars-Peter Clausen <lars@metafoo.de> > > --- > > Changes since v2: > - None. Patch added in v3 > > Changes since v1: > - None. Patch added in v3 > > drivers/staging/iio/adc/ad7280a.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/iio/adc/ad7280a.c > b/drivers/staging/iio/adc/ad7280a.c > index 19a5f244dcae..bef6bd1295ea 100644 > --- a/drivers/staging/iio/adc/ad7280a.c > +++ b/drivers/staging/iio/adc/ad7280a.c > @@ -824,6 +824,10 @@ static irqreturn_t ad7280_event_handler(int irq, void > *private) > return IRQ_HANDLED; > } > > +/* Note: No need to fix checkpatch warning that reads: > + * CHECK: spaces preferred around that '-' (ctx:VxV) > + * The function argument is stringified and doesn't need a fix > + */ > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > in_voltage-voltage_thresh_low_value, > 0644,
On Tue, 24 Mar 2020 08:07:28 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Mon, 2020-03-23 at 01:27 +0530, Deepak R Varma wrote: > > [External] > > > > Checkpatch would flash a check message around a stringified macro > > argument containing a '-' character. Add comment to indicate the > > argument is legitimate and doesn't need fixing. > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> One minor thing inline, otherwise thanks for doing this. Jonathan > > > > > Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> > > Suggested-by: Lars-Peter Clausen <lars@metafoo.de> > > > > --- > > > > Changes since v2: > > - None. Patch added in v3 > > > > Changes since v1: > > - None. Patch added in v3 > > > > drivers/staging/iio/adc/ad7280a.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/staging/iio/adc/ad7280a.c > > b/drivers/staging/iio/adc/ad7280a.c > > index 19a5f244dcae..bef6bd1295ea 100644 > > --- a/drivers/staging/iio/adc/ad7280a.c > > +++ b/drivers/staging/iio/adc/ad7280a.c > > @@ -824,6 +824,10 @@ static irqreturn_t ad7280_event_handler(int irq, void > > *private) > > return IRQ_HANDLED; > > } > > > > +/* Note: No need to fix checkpatch warning that reads: Trivial, but please use standard multiline comment syntax (for most but not all of the kernel) /* * Note: .. */ > > + * CHECK: spaces preferred around that '-' (ctx:VxV) > > + * The function argument is stringified and doesn't need a fix > > + */ > > static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, > > in_voltage-voltage_thresh_low_value, > > 0644,
diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c index 19a5f244dcae..bef6bd1295ea 100644 --- a/drivers/staging/iio/adc/ad7280a.c +++ b/drivers/staging/iio/adc/ad7280a.c @@ -824,6 +824,10 @@ static irqreturn_t ad7280_event_handler(int irq, void *private) return IRQ_HANDLED; } +/* Note: No need to fix checkpatch warning that reads: + * CHECK: spaces preferred around that '-' (ctx:VxV) + * The function argument is stringified and doesn't need a fix + */ static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value, in_voltage-voltage_thresh_low_value, 0644,
Checkpatch would flash a check message around a stringified macro argument containing a '-' character. Add comment to indicate the argument is legitimate and doesn't need fixing. Signed-off-by: Deepak R Varma <mh12gx2825@gmail.com> Suggested-by: Lars-Peter Clausen <lars@metafoo.de> --- Changes since v2: - None. Patch added in v3 Changes since v1: - None. Patch added in v3 drivers/staging/iio/adc/ad7280a.c | 4 ++++ 1 file changed, 4 insertions(+)