[OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG
diff mbox series

Message ID 20200323143835.46117-1-roger.pau@citrix.com
State New
Headers show
Series
  • [OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG
Related show

Commit Message

Roger Pau Monné March 23, 2020, 2:38 p.m. UTC
This allows a PVH/HVM domain to use unpopulated memory ranges to map
foreign memory or grants, and is required for a PVH dom0 to function
properly.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
 ts-kernel-build | 1 +
 1 file changed, 1 insertion(+)

Comments

Ian Jackson March 24, 2020, 11:55 a.m. UTC | #1
Roger Pau Monne writes ("[PATCH OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG"):
> This allows a PVH/HVM domain to use unpopulated memory ranges to map
> foreign memory or grants, and is required for a PVH dom0 to function
> properly.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

I will push this to pretest immediately.

Thanks,
Ian.
Roger Pau Monné March 24, 2020, noon UTC | #2
Adding Juergen and Boris for feedback.

On Tue, Mar 24, 2020 at 11:57:48AM +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG"):
> > Roger Pau Monne writes ("[PATCH OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG"):
> > > This allows a PVH/HVM domain to use unpopulated memory ranges to map
> > > foreign memory or grants, and is required for a PVH dom0 to function
> > > properly.
> > > 
> > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> > 
> > I will push this to pretest immediately.
> 
> Now done.  Would you consider whether the default should be changed
> in Linux and prepare a patch to do so if appropriate ?

DYK if there's any reason why this is not on by default?

Thanks, Roger.
Jürgen Groß March 24, 2020, 1:08 p.m. UTC | #3
On 24.03.20 13:00, Roger Pau Monné wrote:
> Adding Juergen and Boris for feedback.
> 
> On Tue, Mar 24, 2020 at 11:57:48AM +0000, Ian Jackson wrote:
>> Ian Jackson writes ("Re: [PATCH OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG"):
>>> Roger Pau Monne writes ("[PATCH OSSTEST] kernel-build: enable XEN_BALLOON_MEMORY_HOTPLUG"):
>>>> This allows a PVH/HVM domain to use unpopulated memory ranges to map
>>>> foreign memory or grants, and is required for a PVH dom0 to function
>>>> properly.
>>>>
>>>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>>>
>>> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>>>
>>> I will push this to pretest immediately.
>>
>> Now done.  Would you consider whether the default should be changed
>> in Linux and prepare a patch to do so if appropriate ?
> 
> DYK if there's any reason why this is not on by default?

AFAIK the default has been off since introduction in 2011.

I don't know the reason for that.


Juergen

Patch
diff mbox series

diff --git a/ts-kernel-build b/ts-kernel-build
index c976289e..89cdafcb 100755
--- a/ts-kernel-build
+++ b/ts-kernel-build
@@ -511,6 +511,7 @@  setopt CONFIG_XEN_KBDDEV_FRONTEND y
 setopt CONFIG_XEN_FBDEV_FRONTEND y
 setopt CONFIG_XEN_PCIDEV_FRONTEND y
 setopt CONFIG_XEN_BALLOON y
+setopt CONFIG_XEN_BALLOON_MEMORY_HOTPLUG y
 setopt CONFIG_XEN_SCRUB_PAGES y
 setopt CONFIG_XEN_DEV_EVTCHN y
 setopt CONFIG_XEN_BACKEND y