| Message ID | 20200324071030.19801-2-peter.chen@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3,1/2] phy: cadence: salvo: add salvo phy driver | expand |
> > Add Cadence SALVO PHY binding doc, this PHY is a legacy module, > and is only used for USB3 and USB2. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Changes for v3: > - Fix more schema errors > > .../bindings/phy/cdns,salvo-phy.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > new file mode 100644 > index 000000000000..a36e21e1808c > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2020 NXP > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/cdns,salvo-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Cadence SALVO PHY > + > +maintainers: > + - Peter Chen <peter.chen@nxp.com> > + > +properties: > + compatible: > + enum: > + - nxp,salvo-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: salvo_phy_clk > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/firmware/imx/rsrc.h> > + > + usb3phy: usb3-phy@5B160000 { > + compatible = "nxp,salvo-phy"; > + reg = <0x5B160000 0x40000>; > + clocks = <&usb3_lpcg 4>; > + clock-names = "salvo_phy_clk"; > + power-domains = <&pd IMX_SC_R_USB_2_PHY>; > + #phy-cells = <0>; > + }; > -- > 2.17.1 > A gental ping :) Peter
On Tue, Mar 24, 2020 at 03:10:30PM +0800, Peter Chen wrote: > Add Cadence SALVO PHY binding doc, this PHY is a legacy module, > and is only used for USB3 and USB2. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> > --- > Changes for v3: > - Fix more schema errors > > .../bindings/phy/cdns,salvo-phy.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > new file mode 100644 > index 000000000000..a36e21e1808c > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (c) 2020 NXP > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/cdns,salvo-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Cadence SALVO PHY > + > +maintainers: > + - Peter Chen <peter.chen@nxp.com> > + > +properties: > + compatible: > + enum: > + - nxp,salvo-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + items: > + - const: salvo_phy_clk > + > + power-domains: > + maxItems: 1 > + description: phandle to the associated power domain Drop. That's every power-domains property. > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/firmware/imx/rsrc.h> > + > + usb3phy: usb3-phy@5B160000 { Should be lowercase hex. > + compatible = "nxp,salvo-phy"; > + reg = <0x5B160000 0x40000>; > + clocks = <&usb3_lpcg 4>; > + clock-names = "salvo_phy_clk"; > + power-domains = <&pd IMX_SC_R_USB_2_PHY>; > + #phy-cells = <0>; > + }; > -- > 2.17.1 >
On 24/03/20, Peter Chen wrote: > Add Cadence SALVO PHY binding doc, this PHY is a legacy module, > and is only used for USB3 and USB2. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> Tested-by: Oliver Graute <oliver.graute@kococonnector.com>
On 24/03/20, Peter Chen wrote: > Add Cadence SALVO PHY binding doc, this PHY is a legacy module, > and is only used for USB3 and USB2. > > Signed-off-by: Peter Chen <peter.chen@nxp.com> Tested-by: Oliver Graute <oliver.graute@kococonnector.com>
diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml new file mode 100644 index 000000000000..a36e21e1808c --- /dev/null +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml @@ -0,0 +1,53 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (c) 2020 NXP +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/phy/cdns,salvo-phy.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Cadence SALVO PHY + +maintainers: + - Peter Chen <peter.chen@nxp.com> + +properties: + compatible: + enum: + - nxp,salvo-phy + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: salvo_phy_clk + + power-domains: + maxItems: 1 + description: phandle to the associated power domain + + "#phy-cells": + const: 0 + +required: + - compatible + - reg + - "#phy-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/firmware/imx/rsrc.h> + + usb3phy: usb3-phy@5B160000 { + compatible = "nxp,salvo-phy"; + reg = <0x5B160000 0x40000>; + clocks = <&usb3_lpcg 4>; + clock-names = "salvo_phy_clk"; + power-domains = <&pd IMX_SC_R_USB_2_PHY>; + #phy-cells = <0>; + };
Add Cadence SALVO PHY binding doc, this PHY is a legacy module, and is only used for USB3 and USB2. Signed-off-by: Peter Chen <peter.chen@nxp.com> --- Changes for v3: - Fix more schema errors .../bindings/phy/cdns,salvo-phy.yaml | 53 +++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml