mbox

[PULL,0/5] Linux user for 5.0 patches

Message ID 20200324100311.588288-1-laurent@vivier.eu (mailing list archive)
State New, archived
Headers show

Pull-request

git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request

Message

Laurent Vivier March 24, 2020, 10:03 a.m. UTC 
The following changes since commit 29e0855c5af62bbb0b0b6fed792e004dad92ba95:

  Merge remote-tracking branch 'remotes/elmarco/tags/slirp-pull-request' into staging (2020-03-22 21:00:38 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request

for you to fetch changes up to 2582e3016c674c61abe38503c51fd8adffc0d0b3:

  linux-user: Flush out implementation of gettimeofday (2020-03-23 16:12:36 +0100)

----------------------------------------------------------------
Emulate x86_64 vsyscall

----------------------------------------------------------------

Richard Henderson (5):
  target/i386: Renumber EXCP_SYSCALL
  linux-user/i386: Split out gen_signal
  linux-user/i386: Emulate x86_64 vsyscalls
  linux-user: Add x86_64 vsyscall page to /proc/self/maps
  linux-user: Flush out implementation of gettimeofday

 linux-user/i386/cpu_loop.c | 201 ++++++++++++++++++++++++++-----------
 linux-user/syscall.c       |  39 ++++++-
 target/i386/cpu.h          |  12 ++-
 target/i386/translate.c    |  14 ++-
 4 files changed, 200 insertions(+), 66 deletions(-)

Comments

no-reply@patchew.org March 24, 2020, 11 a.m. UTC | #1 
Patchew URL: https://patchew.org/QEMU/20200324100311.588288-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 0/5] Linux user for 5.0 patches
Message-id: 20200324100311.588288-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
58fa059 linux-user: Flush out implementation of gettimeofday
f253e7a linux-user: Add x86_64 vsyscall page to /proc/self/maps
ad06327 linux-user/i386: Emulate x86_64 vsyscalls
2dccb44 linux-user/i386: Split out gen_signal
1ab05c1 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/5 Checking commit 1ab05c10ed02 (target/i386: Renumber EXCP_SYSCALL)
2/5 Checking commit 2dccb4427740 (linux-user/i386: Split out gen_signal)
3/5 Checking commit ad0632716d07 (linux-user/i386: Emulate x86_64 vsyscalls)
4/5 Checking commit f253e7a47cf4 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
ERROR: trailing whitespace
#32: FILE: linux-user/syscall.c:7152:
+    dprintf(fd, TARGET_FMT_lx "-" TARGET_FMT_lx $

total: 1 errors, 0 warnings, 16 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 58fa0592ae77 (linux-user: Flush out implementation of gettimeofday)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200324100311.588288-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Laurent Vivier March 24, 2020, 11:06 a.m. UTC | #2 
Le 24/03/2020 à 12:00, no-reply@patchew.org a écrit :
> Patchew URL: https://patchew.org/QEMU/20200324100311.588288-1-laurent@vivier.eu/
> 
> 
> 
> Hi,
> 
> This series seems to have some coding style problems. See output below for
> more information:
> 
> Subject: [PULL 0/5] Linux user for 5.0 patches
> Message-id: 20200324100311.588288-1-laurent@vivier.eu
> Type: series
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
> 
> Switched to a new branch 'test'
> 58fa059 linux-user: Flush out implementation of gettimeofday
> f253e7a linux-user: Add x86_64 vsyscall page to /proc/self/maps
> ad06327 linux-user/i386: Emulate x86_64 vsyscalls
> 2dccb44 linux-user/i386: Split out gen_signal
> 1ab05c1 target/i386: Renumber EXCP_SYSCALL
> 
> === OUTPUT BEGIN ===
> 1/5 Checking commit 1ab05c10ed02 (target/i386: Renumber EXCP_SYSCALL)
> 2/5 Checking commit 2dccb4427740 (linux-user/i386: Split out gen_signal)
> 3/5 Checking commit ad0632716d07 (linux-user/i386: Emulate x86_64 vsyscalls)
> 4/5 Checking commit f253e7a47cf4 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
> ERROR: trailing whitespace
> #32: FILE: linux-user/syscall.c:7152:
> +    dprintf(fd, TARGET_FMT_lx "-" TARGET_FMT_lx $
> 
> total: 1 errors, 0 warnings, 16 lines checked
> 
> Patch 4/5 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 5/5 Checking commit 58fa0592ae77 (linux-user: Flush out implementation of gettimeofday)
> === OUTPUT END ===
> 
> Test command exited with code: 1
> 
> 
> The full log is available at
> http://patchew.org/logs/20200324100311.588288-1-laurent@vivier.eu/testing.checkpatch/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
> 

Sorry, fixed that on previous PR, not in this new one.

I'm going to send a v2 shortly.

Thanks,
Laurent
no-reply@patchew.org March 24, 2020, 12:32 p.m. UTC | #3 
Patchew URL: https://patchew.org/QEMU/20200324100311.588288-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 0/5] Linux user for 5.0 patches
Message-id: 20200324100311.588288-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200324121216.23899-1-peter.maydell@linaro.org -> patchew/20200324121216.23899-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200324121636.24136-1-berto@igalia.com -> patchew/20200324121636.24136-1-berto@igalia.com
 * [new tag]         patchew/20200324122044.1131326-1-mreitz@redhat.com -> patchew/20200324122044.1131326-1-mreitz@redhat.com
Switched to a new branch 'test'
cd99da6 linux-user: Flush out implementation of gettimeofday
94aeacd linux-user: Add x86_64 vsyscall page to /proc/self/maps
4555b29 linux-user/i386: Emulate x86_64 vsyscalls
b4652ed linux-user/i386: Split out gen_signal
7915a1d target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/5 Checking commit 7915a1d69d09 (target/i386: Renumber EXCP_SYSCALL)
2/5 Checking commit b4652edb33e9 (linux-user/i386: Split out gen_signal)
3/5 Checking commit 4555b297005d (linux-user/i386: Emulate x86_64 vsyscalls)
4/5 Checking commit 94aeacd76e83 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
ERROR: trailing whitespace
#32: FILE: linux-user/syscall.c:7152:
+    dprintf(fd, TARGET_FMT_lx "-" TARGET_FMT_lx $

total: 1 errors, 0 warnings, 16 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit cd99da680137 (linux-user: Flush out implementation of gettimeofday)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200324100311.588288-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com