| Message ID | 20200324102030.31000-2-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: dwc3: meson: add OTG support for GXL/GXM | expand |
Hi Neil, On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong <narmstrong@baylibre.com> wrote: [...] > --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml > @@ -25,9 +25,13 @@ description: | > The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in > host-only mode. > > + The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY. > + > properties: > compatible: > enum: > + - amlogic,meson-gxl-usb-ctrl > + - amlogic,meson-gxm-usb-ctrl > - amlogic,meson-g12a-usb-ctrl > - amlogic,meson-a1-usb-ctrl the phy-names property is described below which you don't update please add usb2-phy2 to the list of allowed phy-names so the dt binding validation for the .dtsi patche (#9) won't complain With that fixed: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Martin
On 24/03/2020 15:06, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Mar 24, 2020 at 11:20 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > [...] >> --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >> +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml >> @@ -25,9 +25,13 @@ description: | >> The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in >> host-only mode. >> >> + The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY. >> + >> properties: >> compatible: >> enum: >> + - amlogic,meson-gxl-usb-ctrl >> + - amlogic,meson-gxm-usb-ctrl >> - amlogic,meson-g12a-usb-ctrl >> - amlogic,meson-a1-usb-ctrl > the phy-names property is described below which you don't update > please add usb2-phy2 to the list of allowed phy-names so the dt > binding validation for the .dtsi patche (#9) won't complain Missed this one, thanks ! Neil > > With that fixed: > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > Martin >
diff --git a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml index b0e5e0fe9386..e9afedbe8424 100644 --- a/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml +++ b/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml @@ -25,9 +25,13 @@ description: | The Amlogic A1 embeds a DWC3 USB IP Core configured for USB2 in host-only mode. + The Amlogic GXL & GXM SoCs doesn't embed an USB3 PHY. + properties: compatible: enum: + - amlogic,meson-gxl-usb-ctrl + - amlogic,meson-gxm-usb-ctrl - amlogic,meson-g12a-usb-ctrl - amlogic,meson-a1-usb-ctrl @@ -89,6 +93,23 @@ required: - dr_mode allOf: + - if: + properties: + compatible: + enum: + - amlogic,meson-gxl-usb-ctrl + - amlogic,meson-gxm-usb-ctrl + + then: + properties: + clocks: + minItems: 2 + clock-names: + items: + - const: usb_ctrl + - const: ddr + required: + - clock-names - if: properties: compatible:
The Amlogic GXL and GXM is slightly different from the Amlogic G12A Glue. The GXL SoCs only embeds 2 USB2 PHYs and no USB3 PHYs, and the GXM SoCs embeds 3 USB2 PHYs. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- .../usb/amlogic,meson-g12a-usb-ctrl.yaml | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+)