| Message ID | 20200324153630.11882-5-vsementsov@virtuozzo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Several error use-after-free | expand |
* Vladimir Sementsov-Ogievskiy (vsementsov@virtuozzo.com) wrote: > local_err is used again in secondary_vm_do_failover() after > replication_stop_all(), so we must zero it. Otherwise try to set > non-NULL local_err will crash. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com> I'll queue this > --- > migration/colo.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/migration/colo.c b/migration/colo.c > index 44942c4e23..a54ac84f41 100644 > --- a/migration/colo.c > +++ b/migration/colo.c > @@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void) > replication_stop_all(true, &local_err); > if (local_err) { > error_report_err(local_err); > + local_err = NULL; > } > > /* Notify all filters of all NIC to do checkpoint */ > -- > 2.21.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
diff --git a/migration/colo.c b/migration/colo.c index 44942c4e23..a54ac84f41 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -93,6 +93,7 @@ static void secondary_vm_do_failover(void) replication_stop_all(true, &local_err); if (local_err) { error_report_err(local_err); + local_err = NULL; } /* Notify all filters of all NIC to do checkpoint */
local_err is used again in secondary_vm_do_failover() after replication_stop_all(), so we must zero it. Otherwise try to set non-NULL local_err will crash. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> --- migration/colo.c | 1 + 1 file changed, 1 insertion(+)